From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 239D43858015 for ; Tue, 1 Nov 2022 02:00:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 239D43858015 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1667268036; bh=D3WQoUeJf/VCJqFU+ym7vMcRHkl/2inxvffAVTe2bkw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=J+8E3n76pxSUbI9uH5j0OCYZDuCx6GWunMEEelIKWwk4kw/SKgQQGf0kZ3JteB1xi aVUKMcqtvYpbrt8wmnsc8pHnDgkNVIDjNnrF31nVRhL3YDqsCK9ehfUQ2MlvAoC0MC NTTaM1xRI/yguYg4Y3JuZNIOq8aurpCcBMhUQCpY= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 0C8A7667FB; Mon, 31 Oct 2022 22:00:34 -0400 (EDT) Message-ID: Subject: Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1]. From: Xi Ruoyao To: Carlos O'Donell , caiyinyu , adhemerval.zanella@linaro.org Cc: i.swmail@xen0n.name, libc-alpha@sourceware.org Date: Tue, 01 Nov 2022 10:00:32 +0800 In-Reply-To: References: <20221031034334.3027740-1-caiyinyu@loongson.cn> <0a618c5f8c1d5a621e157a6167048c102fd8d501.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,GIT_PATCH_0,LIKELY_SPAM_FROM,PDS_OTHER_BAD_TLD,SPF_HELO_PASS,SPF_PASS,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2022-10-31 at 09:12 -0400, Carlos O'Donell wrote: > On 10/31/22 02:34, Xi Ruoyao via Libc-alpha wrote: > > On Mon, 2022-10-31 at 11:43 +0800, caiyinyu wrote: > > > [1]: > > > https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=3Dc= 4a7e6b56218e1d5a858682186b542e2eae01a4a;hp=3D0d94a8735055432029237612a6eb91= 65db1ec9dd > > > [2]: > > > Reference: https://loongson.github.io/LoongArch-Documentation/LoongAr= ch-ELF-ABI-EN.html#_e_flags_identifies_abi_type_and_version > > > --- > > > =C2=A0elf/elf.h | 6 ++++-- > > > =C2=A01 file changed, 4 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/elf/elf.h b/elf/elf.h > > > index 3f08823a30..383eb5fbff 100644 > > > --- a/elf/elf.h > > > +++ b/elf/elf.h > > > @@ -4093,8 +4093,10 @@ enum > > > =C2=A0#define R_NDS32_TLS_DESC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0119 > > > =C2=A0 > > > =C2=A0/* LoongArch ELF Flags */ > > > -#define EF_LARCH_ABI=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A00x07 >=20 > I assume this is a mask for the bits. >=20 > > > -#define EF_LARCH_ABI_LP64D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x03 > >=20 > > Does Glibc API policy allow to remove a macro definition in a public > > header? >=20 > If a public glibc release has been made of this header then it is public = ABI. >=20 > How big is the LoongArch community? You could remove these things if you = wanted, > but it is not good for existing source compatibility. > =C2=A0 > > > +#define EF_LOONGARCH_ABI_SOFT_FLOAT=C2=A0=C2=A0=C2=A0=C2=A0 0x1 > > > +#define EF_LOONGARCH_ABI_SINGLE_FLOAT=C2=A0=C2=A0 0x2 > > > +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT=C2=A0=C2=A0 0x3 Hmm, is "LARCH" -> "LOONGARCH" change intentional here? > Best practice is to keep the old macro names around. >=20 > Add the new macro names. I agree. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University