From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Alexander Monakov <amonakov@ispras.ru>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v5 1/6] stdlib: Optimization qsort{_r} swap implementation
Date: Mon, 17 Jul 2023 11:58:31 -0700 [thread overview]
Message-ID: <a21a79f2-54cd-e91f-b8f6-7cac3662d1a5@cs.ucla.edu> (raw)
In-Reply-To: <cb552815-c2ec-fd58-e91d-bf77117b6410@linaro.org>
On 2023-07-17 11:07, Adhemerval Zanella Netto wrote:
> I am not sure in fact, my take was the code as simple enough to have this
> concern.
The usual rule of thumb is that ten lines are trivial, and that more
than that might be a concern. When it's a concern, you can't simply read
the original code and rewrite it in a different way; you need to
actually rewrite it from scratch, preferably without looking at the
original code. It's a pain, admittedly.
next prev parent reply other threads:[~2023-07-17 18:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:25 [PATCH v5 0/6] Use introsort for qsort Adhemerval Zanella
2023-07-13 13:25 ` [PATCH v5 1/6] stdlib: Optimization qsort{_r} swap implementation Adhemerval Zanella
2023-07-13 22:17 ` Paul Eggert
2023-07-14 1:01 ` Paul Eggert
2023-07-14 12:06 ` Adhemerval Zanella Netto
2023-07-17 16:57 ` Alexander Monakov
2023-07-17 17:29 ` Paul Eggert
2023-07-17 18:07 ` Adhemerval Zanella Netto
2023-07-17 18:58 ` Paul Eggert [this message]
2023-07-17 19:06 ` Adhemerval Zanella Netto
2023-07-18 14:01 ` Adhemerval Zanella Netto
2023-07-18 14:13 ` Adhemerval Zanella Netto
2023-07-13 13:25 ` [PATCH v5 2/6] stdlib: Move insertion sort out qsort Adhemerval Zanella
2023-07-13 13:25 ` [PATCH v5 3/6] stdlib: qsort: Move some macros to inline function Adhemerval Zanella
2023-07-13 13:25 ` [PATCH v5 4/6] stdlib: Implement introsort with qsort (BZ 19305) Adhemerval Zanella
2023-07-13 13:25 ` [PATCH v5 5/6] stdlib: Remove use of mergesort on qsort (BZ 21719) Adhemerval Zanella
2023-07-13 13:25 ` [PATCH v5 6/6] stdlib: Add more qsort{_r} coverage Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a21a79f2-54cd-e91f-b8f6-7cac3662d1a5@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=adhemerval.zanella@linaro.org \
--cc=amonakov@ispras.ru \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).