From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by sourceware.org (Postfix) with ESMTPS id 5DFA5385781A for ; Tue, 16 Nov 2021 18:14:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DFA5385781A Received: by mail-ua1-x92c.google.com with SMTP id v3so44317264uam.10 for ; Tue, 16 Nov 2021 10:14:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=qzJ7ZIJXPj7rgqmScpLPPYwQItA1TzTgXgruMtzZJbk=; b=pFuD3nuFNUo4mrqYJWHCHNfugjUVtiGNq/vk/E6euyYVyYkzwsHfAVU4teUslX+utR zc7KXrdUsVvy0PjjdBhhvivfPkZhc9EYzgU9fR9Zdg59jBBEtkQwExoWYlU29dsQh/EA RCp492tH5eS+lJg/Q+k12ch+lwPUvcLOkXnSfpAwtKAMEH62pZe0BH0NIWnXKUnkGDj+ gIbLXmqKuW9B4LkgguBpIRCOs7DmpXSo1yV/29zu2oTmKqWG6mOaIoaVvlqubw8+ifdT wXZUftTUpgZUy2TzdXbgmPGOCTEqsFYHA7QQeMmJVyyeEq9cN2+bxpaFAyjUcA3+45qH G3mw== X-Gm-Message-State: AOAM530MtlJN5aMXuOlJcyi4HK/xEWKNSzD0bI0gB31MuAGQ0GsnhScG tEMZ7FJCsA7tLcZCmqfuIgcasA== X-Google-Smtp-Source: ABdhPJxkHNncztfI9S2uUh0L/vH09ADhNHa/dFHbcpaaA6smNXW2IcIPuYHHfQe5TJBWlKkNsk9nlw== X-Received: by 2002:a67:b844:: with SMTP id o4mr60419733vsh.61.1637086440803; Tue, 16 Nov 2021 10:14:00 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:66dc:190:a0a5:4184:e499? ([2804:431:c7ca:66dc:190:a0a5:4184:e499]) by smtp.gmail.com with ESMTPSA id t5sm11428206vsk.24.2021.11.16.10.13.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 10:14:00 -0800 (PST) Message-ID: Date: Tue, 16 Nov 2021 15:13:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie Content-Language: en-US From: Adhemerval Zanella To: "H.J. Lu" Cc: Siddhesh Poyarekar , GNU C Library , Szabolcs Nagy References: <2cd4df02-a2e0-9e67-044c-116660855322@gotplt.org> <71cf3196-393b-c1b3-d468-3b7da5aba96b@linaro.org> <00aed799-a7f4-f573-8abe-f8a890994a48@linaro.org> In-Reply-To: <00aed799-a7f4-f573-8abe-f8a890994a48@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 18:14:03 -0000 On 16/11/2021 11:23, Adhemerval Zanella wrote: > > > On 16/11/2021 11:11, H.J. Lu wrote: >> On Tue, Nov 16, 2021 at 5:50 AM Adhemerval Zanella via Libc-alpha >> wrote: >>> >>> >>> >>> On 16/11/2021 10:47, Siddhesh Poyarekar wrote: >>>> Hello, >>>> >>>> It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this? >>>> >>>> The full build log is here: >>>> https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log >>>> >>>> Thanks, >>>> Siddhesh >>>> >>>> >>>> =====FAIL: elf/tst-bz15311.out===== >>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>>> =====FAIL: elf/tst-bz15311.test-result===== >>>> FAIL: elf/tst-bz15311 >>>> original exit status 1 >>>> =====FAIL: elf/tst-dso-ordering1.out===== >>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>>> =====FAIL: elf/tst-dso-ordering1.test-result===== >>>> FAIL: elf/tst-dso-ordering1 >>>> original exit status 1 >>>> =====FAIL: elf/tst-dso-ordering10.out===== >>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>>> =====FAIL: elf/tst-dso-ordering10.test-result===== >>>> FAIL: elf/tst-dso-ordering10 >>>> original exit status 1 >>>> =====FAIL: elf/tst-dso-ordering2.out===== >>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>>> =====FAIL: elf/tst-dso-ordering2.test-result===== >>>> FAIL: elf/tst-dso-ordering2 >>>> original exit status 1 >>>> =====FAIL: elf/tst-dso-ordering3.out===== >>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>>> =====FAIL: elf/tst-dso-ordering3.test-result===== >>>> FAIL: elf/tst-dso-ordering3 >>>> original exit status 1 >>>> =====FAIL: elf/tst-dso-ordering4.out===== >>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test >>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test >>> >>> I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort= >>> is also failing because it is the previous algorithm. >> >> Please try the current master. It may have been fixed. > > Yes, that's my first though about this report. I am running make check on 128 core > aarch64 machine. > It is due my dl-minimal-malloc change (b05fae4d8e34), which requires the same fixed done by 47618209d05a: diff --git a/elf/dl-minimal-malloc.c b/elf/dl-minimal-malloc.c index 939b5271ca..ea9bca26cf 100644 --- a/elf/dl-minimal-malloc.c +++ b/elf/dl-minimal-malloc.c @@ -17,6 +17,11 @@ License along with the GNU C Library; if not, see . */ +/* Mark symbols hidden in static PIE for early self relocation to work. + Note: string.h may have ifuncs which cannot be hidden on i686. */ +#if BUILD_PIE_DEFAULT +# pragma GCC visibility push(hidden) +#endif #include #include #include I will run a make check on aarch64 and x86_64 and push the fix.