From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 947C03858C83 for ; Tue, 8 Mar 2022 15:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 947C03858C83 Received: by mail-ot1-x333.google.com with SMTP id x8-20020a9d6288000000b005b22c373759so5721172otk.8 for ; Tue, 08 Mar 2022 07:44:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2MoGkRRxwUMUfMW0iNDGnmYBFxw0SCUOCzCtZlEH7bQ=; b=MfGQ40RbzHffxCphv7NCuQbnwzbMxvjnmOFYjzG2LDH95yJoGbn5OpuPLb+YKtJNuJ qq/wvRo4HJ2v87+l1Ilc6SUY49GQJMPwwHTBDv8Z/VUznKj1xdJXQOmyXAlY4VkcQJRo OqtxQNS5rir9Jxz50S/ynZx01JIL4M8gPcSPWvyiLwX6nok5VYvkyC8k0tIHE3fNnX51 EkwMyD4jq8e5IsHRF++Jc/rmzHtwEOwDEc/bp2IFmlY9DQis8LshJXYD+Nw7fhGYZww1 UdyNX+lGe8VJ1LlqJl3OntNp1Zg237uxcULEm9gN/2vIscjkBalJQHlUhSKpSDabLxJG ojlQ== X-Gm-Message-State: AOAM531+6e/2AwxaZpECfZtYvpi0/9dCeIn1pQv6ySaLEVKMvbT419du jmEzqhsCmM4l6+qpT3v0GUXfSw== X-Google-Smtp-Source: ABdhPJxZObjkjHOnNpI6isHvkG5+fywbVh/1A9BC+Ulv0hgRVMDnE+AOLOywOHjTjJc+LXhsXXMsIA== X-Received: by 2002:a9d:5f15:0:b0:5af:5928:d5a1 with SMTP id f21-20020a9d5f15000000b005af5928d5a1mr8808769oti.343.1646754241905; Tue, 08 Mar 2022 07:44:01 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:2dcb:7122:6b3a:c840:afc7? ([2804:431:c7ca:2dcb:7122:6b3a:c840:afc7]) by smtp.gmail.com with ESMTPSA id h11-20020a9d6f8b000000b005b230ab0461sm3475859otq.64.2022.03.08.07.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 07:44:01 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 12:43:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 3/3] inet: Return EAI_MEMORY when nrl_domainname() fails to allocate memory Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 15:44:04 -0000 On 08/03/2022 01:12, DJ Delorie wrote: > > Adhemerval Zanella via Libc-alpha writes: >> -static void >> +static bool > > Ok. Please include comment saying what true/false return means, though. Will do, thanks for the review. > LGTM with that one comment added. > > Reviewed-by: DJ Delorie >