From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 99A753858D39 for ; Tue, 19 Jul 2022 02:45:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99A753858D39 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-532-4XGlBBIxPSGrK1lYLv0fHg-1; Mon, 18 Jul 2022 22:45:43 -0400 X-MC-Unique: 4XGlBBIxPSGrK1lYLv0fHg-1 Received: by mail-qt1-f200.google.com with SMTP id u12-20020a05622a010c00b0031ef5b46dc0so2063947qtw.16 for ; Mon, 18 Jul 2022 19:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=rHzB47NgmatlLSkUdYHuHb6AseipwxyS/X3qtCe1Xjs=; b=rAFABip039WNE4H9cwG9DbSoMHwlWexkZwhJ8CTOWhbuEPC6y+UYxqiTpesbLuQycn dzPeRuW8LVS8ghteOnEst6n3JD+3Q85Wpe9Em4xCuiNUozKShYqgZwsMciIQq6oF02Dn Q8t2Z1ib+yPBP9+mWw1NFhKaYJHXIs73DaLsPn2mj8mY9wQ62IytjcYjpcPomhOYPA6M cSDz9CQbYhxcakrBcYdwHQORYnJL2dcTe8Gt4ieX5VjA/AdYJB2YGfYfRSPB5sWG/bw1 zZg6+6qYgCmwddgPEdd+SabwmeQ2/kK7c3yM6gNgTQ0/aIhCPslJ8HLeAca6NUAYpyKL oAPw== X-Gm-Message-State: AJIora/Sbh7l/SY5JqxbuChCyAI1ZHtcVWVXTp8X1aX3Q7eBJAvMzXsA 7bh7lQhWOnOcBFRgdETfWoMDCThO+HXRAKfwdGvQE4WWaXWUXjCqeXqxdH6ZerL6hNy2AhL/5Pt SfFfC/XEUB9u50KfVu7xf X-Received: by 2002:ac8:9:0:b0:305:3451:f384 with SMTP id a9-20020ac80009000000b003053451f384mr23931725qtg.409.1658198742636; Mon, 18 Jul 2022 19:45:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vJ314TCN1/RFL2A4P1+US3EBnyU997ncD6UuWjlaoV/I3/FNHvILyW1LmRvdWsjw30X3Q73g== X-Received: by 2002:ac8:9:0:b0:305:3451:f384 with SMTP id a9-20020ac80009000000b003053451f384mr23931721qtg.409.1658198742405; Mon, 18 Jul 2022 19:45:42 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id g3-20020a05620a40c300b006b5ee4de4fbsm3859461qko.37.2022.07.18.19.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 19:45:41 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 22:45:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Increase the timeout of locale/tst-localedef-path-norm To: Adhemerval Zanella Netto , Mark Wielaard , libc-alpha@sourceware.org Cc: Mark Wielaard References: <20220718134208.969938-1-mjw@redhat.com> <93b294cf-e50e-f5b6-5f7a-96f04c92adfe@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <93b294cf-e50e-f5b6-5f7a-96f04c92adfe@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 02:45:46 -0000 On 7/18/22 15:50, Adhemerval Zanella Netto via Libc-alpha wrote: > > > On 18/07/22 10:42, Mark Wielaard via Libc-alpha wrote: >> From: Mark Wielaard >> >> On the current AArch64 buildbot glibc-fedora-arm64 >> the 30s timeout is not enough to run this test, the >> machine has 8 cores, but the testcase is deliberately >> single threaded >> >> make test t=locale/tst-localedef-path-norm >> >> takes about 45s, so I increased the timeout to 60s. >> >> This is the only failure on this buildbot builder. >> https://builder.sourceware.org/buildbot/#/builders/glibc-fedora-arm64 >> --- >> locale/tst-localedef-path-norm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/locale/tst-localedef-path-norm.c b/locale/tst-localedef-path-norm.c >> index 68995a415..80e1c556d 100644 >> --- a/locale/tst-localedef-path-norm.c >> +++ b/locale/tst-localedef-path-norm.c >> @@ -236,5 +236,5 @@ do_test (void) >> return 0; >> } >> >> -#define TIMEOUT 30 >> +#define TIMEOUT 60 A default timeout of 60s is too long. You need to increase TIMEOUTFACTOR if you have a slow disk attached to the system under test. >> #include > > I think it would be maybe better to either split the test, so we can > improve make check parallel runtime; or use a large TIMEOUTFACTOR. We could. There is a balance here because the tests need root and write to / to exercise the path normalization code. My comment from 2020 explains this balance. 102 /* It takes ~10 seconds to serially execute 9 localedef test. We 103 could run the compilations in parallel if we want to reduce test 104 time. We don't want to split this out into distinct tests because 105 it would require multiple chroots. Batching the same localedef 106 tests saves disk space during testing. */ -- Cheers, Carlos.