From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nixiaoming@huawei.com>
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by sourceware.org (Postfix) with ESMTPS id 5C8163858D3C;
 Thu,  5 May 2022 08:23:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C8163858D3C
Received: from canpemm500006.china.huawei.com (unknown [172.30.72.56])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Kv6B55HKTz1JBrL;
 Thu,  5 May 2022 16:22:05 +0800 (CST)
Received: from [10.67.110.83] (10.67.110.83) by canpemm500006.china.huawei.com
 (7.192.105.130) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May
 2022 16:23:09 +0800
Subject: Re: [PATCH v2 4/4] clock_settime/clock_gettime: Use __nonnull to
 avoid null pointer
To: Siddhesh Poyarekar <siddhesh@sourceware.org>, <drepper@redhat.com>,
 <lukma@denx.de>, <adrian.ratiu@collabora.com>, <schwab@linux-m68k.org>,
 <fweimer@redhat.com>, <adhemerval.zanella@linaro.org>
CC: <libc-alpha@sourceware.org>, <wangle6@huawei.com>
References: <20220428122529.108208-1-nixiaoming@huawei.com>
 <20220505030111.111197-1-nixiaoming@huawei.com>
 <20220505030111.111197-5-nixiaoming@huawei.com>
 <be3a87a8-a067-74a2-e236-8e0d6f515802@sourceware.org>
From: Xiaoming Ni <nixiaoming@huawei.com>
Message-ID: <a356be76-cbbd-4843-68b2-acb69211d6a4@huawei.com>
Date: Thu, 5 May 2022 16:23:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.0.1
MIME-Version: 1.0
In-Reply-To: <be3a87a8-a067-74a2-e236-8e0d6f515802@sourceware.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.110.83]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 canpemm500006.china.huawei.com (7.192.105.130)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_MANYTO, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2022 08:23:14 -0000

On 2022/5/5 12:26, Siddhesh Poyarekar wrote:
> On 05/05/2022 08:31, Xiaoming Ni via Libc-alpha wrote:
>> clock_settime()
>> clock_settime64()
>> clock_gettime()
>> clock_gettime64()
>> Add __nonnull((2)) to avoid null pointer access.
>>
>> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27662
>> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29084
>> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
>> ---
> 
> LGTM.
> 
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> 
> Do you have commit access or do you need someone to push this for you?
> 
> Thanks,
> Siddhesh
> 
> .
I don't have the permission to push directly.
Can you help push this patch set?

Thanks
Xiaoming Ni
.