public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [10/12] Add femode_t functions: s390
@ 2016-09-02 21:58 Joseph Myers
  2016-09-03 14:38 ` Yury Norov
  2016-09-05 11:17 ` Stefan Liebler
  0 siblings, 2 replies; 5+ messages in thread
From: Joseph Myers @ 2016-09-02 21:58 UTC (permalink / raw)
  To: libc-alpha; +Cc: stli

This patch adds S/390 versions of fegetmode and fesetmode.  Untested.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/s390/fpu/fegetmode.c: New file.
	* sysdeps/s390/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/s390/fpu/fegetmode.c b/sysdeps/s390/fpu/fegetmode.c
new file mode 100644
index 0000000..a6e67c2
--- /dev/null
+++ b/sysdeps/s390/fpu/fegetmode.c
@@ -0,0 +1,27 @@
+/* Store current floating-point control modes.  S/390 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  _FPU_GETCW (*modep);
+  return 0;
+}
diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
new file mode 100644
index 0000000..8feb9b6
--- /dev/null
+++ b/sysdeps/s390/fpu/fesetmode.c
@@ -0,0 +1,38 @@
+/* Install given floating-point control modes.  S/390 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+#include <fenv_libc.h>
+
+#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK)
+
+int
+fesetmode (const femode_t *modep)
+{
+  fpu_control_t fpc;
+
+  _FPU_GETCW (fpc);
+  if (modep == FE_DFL_ENV)
+    fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT;
+  else
+    fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS);
+  _FPU_SETCW (fpc);
+
+  return 0;
+}

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [10/12] Add femode_t functions: s390
  2016-09-02 21:58 [10/12] Add femode_t functions: s390 Joseph Myers
@ 2016-09-03 14:38 ` Yury Norov
  2016-09-03 14:48   ` Yury Norov
  2016-09-05 11:17 ` Stefan Liebler
  1 sibling, 1 reply; 5+ messages in thread
From: Yury Norov @ 2016-09-03 14:38 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha, stli

On Fri, Sep 02, 2016 at 09:58:37PM +0000, Joseph Myers wrote:

[...]

> diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
> new file mode 100644
> index 0000000..8feb9b6
> --- /dev/null
> +++ b/sysdeps/s390/fpu/fesetmode.c
> @@ -0,0 +1,38 @@
> +/* Install given floating-point control modes.  S/390 version.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <fenv.h>
> +#include <fpu_control.h>
> +#include <fenv_libc.h>
> +
> +#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK)
> +
> +int
> +fesetmode (const femode_t *modep)
> +{
> +  fpu_control_t fpc;
> +
> +  _FPU_GETCW (fpc);
> +  if (modep == FE_DFL_ENV)
> +    fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT;
> +  else
> +    fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS);

You do fpc = (fpc & FPC_STATUS) in both branches of condition.
So you can save few instruction if move this snippet upper,
and also increase readability.

Not sure how much gcc-s390 is smart, maybe it can do it for you, but
readability is still in case.

> +  _FPU_SETCW (fpc);
> +
> +  return 0;
> +}
> 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [10/12] Add femode_t functions: s390
  2016-09-03 14:38 ` Yury Norov
@ 2016-09-03 14:48   ` Yury Norov
  2016-09-05 15:16     ` Joseph Myers
  0 siblings, 1 reply; 5+ messages in thread
From: Yury Norov @ 2016-09-03 14:48 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha, stli

On Sat, Sep 03, 2016 at 05:38:32PM +0300, Yury Norov wrote:
> On Fri, Sep 02, 2016 at 09:58:37PM +0000, Joseph Myers wrote:
> 
> [...]
> 
> > diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
> > new file mode 100644
> > index 0000000..8feb9b6
> > --- /dev/null
> > +++ b/sysdeps/s390/fpu/fesetmode.c
> > @@ -0,0 +1,38 @@
> > +/* Install given floating-point control modes.  S/390 version.
> > +   Copyright (C) 2016 Free Software Foundation, Inc.
> > +   This file is part of the GNU C Library.
> > +
> > +   The GNU C Library is free software; you can redistribute it and/or
> > +   modify it under the terms of the GNU Lesser General Public
> > +   License as published by the Free Software Foundation; either
> > +   version 2.1 of the License, or (at your option) any later version.
> > +
> > +   The GNU C Library is distributed in the hope that it will be useful,
> > +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > +   Lesser General Public License for more details.
> > +
> > +   You should have received a copy of the GNU Lesser General Public
> > +   License along with the GNU C Library; if not, see
> > +   <http://www.gnu.org/licenses/>.  */
> > +
> > +#include <fenv.h>
> > +#include <fpu_control.h>
> > +#include <fenv_libc.h>
> > +
> > +#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK)
> > +
> > +int
> > +fesetmode (const femode_t *modep)
> > +{
> > +  fpu_control_t fpc;
> > +
> > +  _FPU_GETCW (fpc);
> > +  if (modep == FE_DFL_ENV)
> > +    fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT;
> > +  else
> > +    fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS);
> 
> You do fpc = (fpc & FPC_STATUS) in both branches of condition.
> So you can save few instruction if move this snippet upper,
> and also increase readability.
> 
> Not sure how much gcc-s390 is smart, maybe it can do it for you, but
> readability is still in case.

The same is true for sh, spark, mips and hppa.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [10/12] Add femode_t functions: s390
  2016-09-02 21:58 [10/12] Add femode_t functions: s390 Joseph Myers
  2016-09-03 14:38 ` Yury Norov
@ 2016-09-05 11:17 ` Stefan Liebler
  1 sibling, 0 replies; 5+ messages in thread
From: Stefan Liebler @ 2016-09-05 11:17 UTC (permalink / raw)
  To: libc-alpha

On 09/02/2016 11:58 PM, Joseph Myers wrote:
> This patch adds S/390 versions of fegetmode and fesetmode.  Untested.
>
> 2016-09-02  Joseph Myers  <joseph@codesourcery.com>
>
> 	* sysdeps/s390/fpu/fegetmode.c: New file.
> 	* sysdeps/s390/fpu/fesetmode.c: Likewise.
>
> diff --git a/sysdeps/s390/fpu/fegetmode.c b/sysdeps/s390/fpu/fegetmode.c
> new file mode 100644
> index 0000000..a6e67c2
> --- /dev/null
> +++ b/sysdeps/s390/fpu/fegetmode.c
> @@ -0,0 +1,27 @@
> +/* Store current floating-point control modes.  S/390 version.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <fenv.h>
> +#include <fpu_control.h>
> +
> +int
> +fegetmode (femode_t *modep)
> +{
> +  _FPU_GETCW (*modep);
> +  return 0;
> +}
> diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
> new file mode 100644
> index 0000000..8feb9b6
> --- /dev/null
> +++ b/sysdeps/s390/fpu/fesetmode.c
> @@ -0,0 +1,38 @@
> +/* Install given floating-point control modes.  S/390 version.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <fenv.h>
> +#include <fpu_control.h>
> +#include <fenv_libc.h>
> +
> +#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK)
> +
> +int
> +fesetmode (const femode_t *modep)
> +{
> +  fpu_control_t fpc;
> +
> +  _FPU_GETCW (fpc);
> +  if (modep == FE_DFL_ENV)
> +    fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT;
> +  else
> +    fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS);
> +  _FPU_SETCW (fpc);
> +
> +  return 0;
> +}
>

Hi Joseph,

please compare against FE_DFL_MODE as you would compare different 
pointer types instead:
diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
index 8feb9b6..f95a777 100644
--- a/sysdeps/s390/fpu/fesetmode.c
+++ b/sysdeps/s390/fpu/fesetmode.c
@@ -28,7 +28,7 @@ fesetmode (const femode_t *modep)
    fpu_control_t fpc;

    _FPU_GETCW (fpc);
-  if (modep == FE_DFL_ENV)
+  if (modep == FE_DFL_MODE)
      fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT;
    else
      fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS);


Afterwards, glibc builds on s390/s390x and the new testcases run 
successfully.

Only as a side note to Yuri's comment:
gcc-s390 is smart enough and moves the (fpc & FPC_STATUS) up.
Furthermore it omits the or'ing with _FPU_DEFAULT as it is zero.

Thanks.
Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [10/12] Add femode_t functions: s390
  2016-09-03 14:48   ` Yury Norov
@ 2016-09-05 15:16     ` Joseph Myers
  0 siblings, 0 replies; 5+ messages in thread
From: Joseph Myers @ 2016-09-05 15:16 UTC (permalink / raw)
  To: Yury Norov; +Cc: libc-alpha, stli, carlos, davem

On Sat, 3 Sep 2016, Yury Norov wrote:

> > You do fpc = (fpc & FPC_STATUS) in both branches of condition.
> > So you can save few instruction if move this snippet upper,
> > and also increase readability.
> > 
> > Not sure how much gcc-s390 is smart, maybe it can do it for you, but
> > readability is still in case.
> 
> The same is true for sh, spark, mips and hppa.

I've updated the relevant patches.

Add femode_t functions: hppa.

This patch adds HPPA versions of fegetmode and fesetmode.  Untested.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/hppa/fpu/fegetmode.c: New file.
	* sysdeps/hppa/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/hppa/fpu/fegetmode.c b/sysdeps/hppa/fpu/fegetmode.c
new file mode 100644
index 0000000..b307495
--- /dev/null
+++ b/sysdeps/hppa/fpu/fegetmode.c
@@ -0,0 +1,27 @@
+/* Store current floating-point control modes.  HPPA version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  _FPU_GETCW (*modep);
+  return 0;
+}
diff --git a/sysdeps/hppa/fpu/fesetmode.c b/sysdeps/hppa/fpu/fesetmode.c
new file mode 100644
index 0000000..6416dab
--- /dev/null
+++ b/sysdeps/hppa/fpu/fesetmode.c
@@ -0,0 +1,36 @@
+/* Install given floating-point control modes.  HPPA version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+#define FPU_CONTROL_BITS (_FPU_HPPA_MASK_RM | 0x20 | _FPU_HPPA_MASK_INT)
+
+int
+fesetmode (const femode_t *modep)
+{
+  fpu_control_t cw;
+  _FPU_GETCW (cw);
+  cw &= ~FPU_CONTROL_BITS;
+  if (modep == FE_DFL_MODE)
+    cw |= _FPU_DEFAULT;
+  else
+    cw |= *modep & FPU_CONTROL_BITS;
+  _FPU_SETCW (cw);
+  return 0;
+}


Add femode_t functions: mips.

This patch adds MIPS versions of fegetmode and fesetmode.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/mips/fpu/fegetmode.c: New file.
	* sysdeps/mips/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/mips/fpu/fegetmode.c b/sysdeps/mips/fpu/fegetmode.c
new file mode 100644
index 0000000..3754aef
--- /dev/null
+++ b/sysdeps/mips/fpu/fegetmode.c
@@ -0,0 +1,27 @@
+/* Store current floating-point control modes.  MIPS version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  _FPU_GETCW (*modep);
+  return 0;
+}
diff --git a/sysdeps/mips/fpu/fesetmode.c b/sysdeps/mips/fpu/fesetmode.c
new file mode 100644
index 0000000..d15c9eb
--- /dev/null
+++ b/sysdeps/mips/fpu/fesetmode.c
@@ -0,0 +1,38 @@
+/* Install given floating-point control modes.  MIPS version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+#define FCSR_STATUS 0xfe83f07c
+
+int
+fesetmode (const femode_t *modep)
+{
+  fpu_control_t cw;
+
+  _FPU_GETCW (cw);
+  cw &= FCSR_STATUS;
+  if (modep == FE_DFL_MODE)
+    cw |= _FPU_DEFAULT;
+  else
+    cw |= *modep & ~FCSR_STATUS;
+  _FPU_SETCW (cw);
+
+  return 0;
+}


Add femode_t functions: s390.

This patch adds S/390 versions of fegetmode and fesetmode.  Untested.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/s390/fpu/fegetmode.c: New file.
	* sysdeps/s390/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/s390/fpu/fegetmode.c b/sysdeps/s390/fpu/fegetmode.c
new file mode 100644
index 0000000..a6e67c2
--- /dev/null
+++ b/sysdeps/s390/fpu/fegetmode.c
@@ -0,0 +1,27 @@
+/* Store current floating-point control modes.  S/390 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  _FPU_GETCW (*modep);
+  return 0;
+}
diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c
new file mode 100644
index 0000000..85a2f2b
--- /dev/null
+++ b/sysdeps/s390/fpu/fesetmode.c
@@ -0,0 +1,39 @@
+/* Install given floating-point control modes.  S/390 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+#include <fenv_libc.h>
+
+#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK)
+
+int
+fesetmode (const femode_t *modep)
+{
+  fpu_control_t fpc;
+
+  _FPU_GETCW (fpc);
+  fpc &= FPC_STATUS;
+  if (modep == FE_DFL_MODE)
+    fpc |= _FPU_DEFAULT;
+  else
+    fpc |= *modep & ~FPC_STATUS;
+  _FPU_SETCW (fpc);
+
+  return 0;
+}


Add femode_t functions: sh.

This patch adds SH versions of fegetmode and fesetmode.  Untested.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/sh/sh4/fpu/fegetmode.c: New file.
	* sysdeps/sh/sh4/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/sh/sh4/fpu/fegetmode.c b/sysdeps/sh/sh4/fpu/fegetmode.c
new file mode 100644
index 0000000..53691b2
--- /dev/null
+++ b/sysdeps/sh/sh4/fpu/fegetmode.c
@@ -0,0 +1,27 @@
+/* Store current floating-point control modes.  SH4 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  _FPU_GETCW (*modep);
+  return 0;
+}
diff --git a/sysdeps/sh/sh4/fpu/fesetmode.c b/sysdeps/sh/sh4/fpu/fesetmode.c
new file mode 100644
index 0000000..eb1cddc
--- /dev/null
+++ b/sysdeps/sh/sh4/fpu/fesetmode.c
@@ -0,0 +1,38 @@
+/* Install given floating-point control modes.  SH4 version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+#define FPU_STATUS 0x3f07c
+
+int
+fesetmode (const femode_t *modep)
+{
+  fpu_control_t fpscr;
+
+  _FPU_GETCW (fpscr);
+  fpscr &= FPU_STATUS;
+  if (modep == FE_DFL_MODE)
+    fpscr |= _FPU_DEFAULT;
+  else
+    fpscr |= *modep & ~FPU_STATUS;
+  _FPU_SETCW (fpscr);
+
+  return 0;
+}


Add femode_t functions: sparc.

This patch adds SPARC versions of fegetmode and fesetmode.  Untested.

2016-09-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/sparc/fpu/fegetmode.c: New file.
	* sysdeps/sparc/fpu/fesetmode.c: Likewise.

diff --git a/sysdeps/sparc/fpu/fegetmode.c b/sysdeps/sparc/fpu/fegetmode.c
new file mode 100644
index 0000000..68e694e
--- /dev/null
+++ b/sysdeps/sparc/fpu/fegetmode.c
@@ -0,0 +1,26 @@
+/* Store current floating-point control modes.  SPARC version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+
+int
+fegetmode (femode_t *modep)
+{
+  __fenv_stfsr (*modep);
+  return 0;
+}
diff --git a/sysdeps/sparc/fpu/fesetmode.c b/sysdeps/sparc/fpu/fesetmode.c
new file mode 100644
index 0000000..4a0080e
--- /dev/null
+++ b/sysdeps/sparc/fpu/fesetmode.c
@@ -0,0 +1,38 @@
+/* Install given floating-point control modes.  SPARC version.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <fpu_control.h>
+
+#define FPU_CONTROL_BITS 0xcfc00000UL
+
+int
+fesetmode (const femode_t *modep)
+{
+  femode_t fsr;
+
+  __fenv_stfsr (fsr);
+  fsr &= ~FPU_CONTROL_BITS;
+  if (modep == FE_DFL_MODE)
+    fsr |= _FPU_DEFAULT;
+  else
+    fsr |= *modep & FPU_CONTROL_BITS;
+  __fenv_ldfsr (fsr);
+
+  return 0;
+}




-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-09-05 15:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 21:58 [10/12] Add femode_t functions: s390 Joseph Myers
2016-09-03 14:38 ` Yury Norov
2016-09-03 14:48   ` Yury Norov
2016-09-05 15:16     ` Joseph Myers
2016-09-05 11:17 ` Stefan Liebler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).