From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id AD11B3858D39 for ; Mon, 15 Nov 2021 15:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD11B3858D39 Received: by mail-ua1-x934.google.com with SMTP id y5so17926833ual.7 for ; Mon, 15 Nov 2021 07:54:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VuckxRPfSsxWAiqEt14CUiX0odnXHNvXICvr79JKnGY=; b=aY/yj5vu140uJC96dDPjkm+FoO/hyLYeLdI4jBYpOEh37zZydEq76vaRn8tm0ncPTd BjSAXiJIf0nxdaftd9N1XplF6Soqa0Q8/OWAAxQLSGaXfqg3p9g2iZfk2bdiJtZ4R+bY FDG+TDdRm2XZa99RsOmfeFvSI/kjOINeDexsjIxH66lIdbmWRFdM1rJE2Jt5G0px0gnX rwJDign2v3Bv5hTYU8EGHhAlEjbrOgCtlNsRdNb7TGtdI8NltORKsIAZrAc/KTSp+cZq icfF+VDi4tphMGet1ujWpXU8LDplgLVJW+eKrU43DdJzmSg+egpEHg1r+HXEJBB2xsEY 5sHQ== X-Gm-Message-State: AOAM532cYoA5UIUwyKJ1OarkaWGp5LIYfbFVfjyCsaCAzJPFuIVEcG51 FNYBJ7ra2+v/Idjtc+Jnm/12Kg== X-Google-Smtp-Source: ABdhPJzoRp4kJqqh7F9joUsg+Ll5wmqVthYWT6hq9iFXu3+iNS/zFQ/LjAB8QO2jPkPYy69RHuCFzA== X-Received: by 2002:a05:6102:5109:: with SMTP id bm9mr43564746vsb.10.1636991684210; Mon, 15 Nov 2021 07:54:44 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:66dc:13f5:e2fb:5a0d:90? ([2804:431:c7ca:66dc:13f5:e2fb:5a0d:90]) by smtp.gmail.com with ESMTPSA id 3sm9401533vsq.1.2021.11.15.07.54.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 07:54:43 -0800 (PST) Message-ID: Date: Mon, 15 Nov 2021 12:54:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v5 18/22] elf: Issue la_symbind() for bind-now (BZ #23734) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-19-adhemerval.zanella@linaro.org> <87czn6wq02.fsf@oldenburg.str.redhat.com> <0ab5764e-1d94-64e9-ea9f-87539bbb1245@linaro.org> <87ilwth50y.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87ilwth50y.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 15:54:46 -0000 On 15/11/2021 11:23, Florian Weimer wrote: > * Adhemerval Zanella: > >>> I find DL_FIXUP_BINDNOW_ADDR_VALUE very confusing. Why is it safe to >>> extract just the code address from the function descriptor? >> >> That's my understanding because at this point st.st_value points to code >> address, not OPD address. > > But the resulting function descriptor will not contain the right TOC > address, I think. Right, we need to update the toc in such case, as elf_machine_fixup_plt does for _dl_fixup. I will fix it.