From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id C06023939C04 for ; Mon, 8 Mar 2021 13:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C06023939C04 Received: by mail-qt1-x830.google.com with SMTP id o1so7370744qta.13 for ; Mon, 08 Mar 2021 05:26:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SSMBv/UGEBIbnYBoKuRnXcvFdXHsx5vgFufwssMuGTs=; b=nKM538cNlq4QuGT4EQz4CoV5aeQtpdRMaIg90BShh1Qtv3boMsMgpYmbaQaybCu4F4 uo+8Had67raE3ooa1xrhDM7xGZp4SdtUsgG250PI58r/13hUkA25dHHau/1s5CVd5moy ttflw7zbpqD3KB20EDeBtdGHDkKTAkgVFpkZg1C/YnVm677BG0RCZA3qYoJwqAcuSxnD IGkd0nCGzVMUnanmsrKYTWfPS6DUUguNLrspVY6+uvLr6ye3r8XEwd1LB5Y7lP1dnMG5 Xbn2JHWFsk3/MAYJqnrITT+9B0HWI2D53mhQ+8vzI6muUyQzshA3Cngl+DLw5CuCjoQI BUMA== X-Gm-Message-State: AOAM532kyHJIDJbuqnci1gTlHYGDst3OqYDuW9h9VOYgBPUv4pKhTSlU NuCAvBPTpBpXeivkn4Xd40kU2Bs9Es61VQ== X-Google-Smtp-Source: ABdhPJysWyCwJq5Zi90HRbZKM3NC7OI+25obOebR7Jsr4IQ6VcpA5PNtcGZZuxDBXoZFtKP94rXzLw== X-Received: by 2002:ac8:5d89:: with SMTP id d9mr20863053qtx.86.1615209981256; Mon, 08 Mar 2021 05:26:21 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id i8sm3606828qtj.16.2021.03.08.05.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 05:26:21 -0800 (PST) To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha References: <20210305201518.798584-1-adhemerval.zanella@linaro.org> <20210305201518.798584-3-adhemerval.zanella@linaro.org> <87blbx9wdi.fsf@oldenburg.str.redhat.com> <1ffdf637-cf1c-9503-d3d6-a57c57baac08@linaro.org> <878s6xeqt6.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Subject: Re: [PATCH 02/52] linux: Add futimes test Message-ID: Date: Mon, 8 Mar 2021 10:26:18 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <878s6xeqt6.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 13:26:23 -0000 On 08/03/2021 10:08, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 05/03/2021 17:30, Florian Weimer wrote: >>> * Adhemerval Zanella via Libc-alpha: >>> >>>> +#define PREPARE do_prepare >>>> +static void >>>> +do_prepare (int argc, char *argv[]) >>>> +{ >>>> + temp_fd = create_temp_file ("utimes", &testfile); >>>> + TEST_VERIFY_EXIT (temp_fd > 0); >>>> +} >>> >>> I believe this should use /dev/shm. >> >> I still don't this we should gloss over buggy filesystem. > > I view this as exactly the same thing as disabling post-Y2038 for 32-bit > time_t. > > We should make it easy for contributors to test their patches. Tests > where you need to remember why they fail on some systems make this > difficult. On the other hand we are hiding a potentially y2038 issues and reporting a success that might fail when users do use the interface. I do prefer users to actually test and report failures so we can iron out the y2038 support *now*.