From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Benchtests: Remove simple_str(n)casecmp
Date: Wed, 8 Mar 2023 12:23:45 -0300 [thread overview]
Message-ID: <a4d608c5-6127-a3a9-940b-3bc884ae16a3@linaro.org> (raw)
In-Reply-To: <PAWPR08MB8982FBBAA85A14DB1430779883B49@PAWPR08MB8982.eurprd08.prod.outlook.com>
On 08/03/23 08:04, Wilco Dijkstra via Libc-alpha wrote:
>
> Remove the slow byte oriented loops. Adjust iteration count to reduce benchmark time.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
>
> diff --git a/benchtests/bench-strcasecmp.c b/benchtests/bench-strcasecmp.c
> index fcfffdea42d72364d915f65cad98eaf9e11b585e..abc6a216e37b49c352fb84f723f88986c5364fb9 100644
> --- a/benchtests/bench-strcasecmp.c
> +++ b/benchtests/bench-strcasecmp.c
> @@ -23,28 +23,14 @@
> #include "json-lib.h"
>
> typedef int (*proto_t) (const char *, const char *);
> -static int simple_strcasecmp (const char *, const char *);
>
> -IMPL (simple_strcasecmp, 0)
> IMPL (strcasecmp, 1)
>
> -static int
> -simple_strcasecmp (const char *s1, const char *s2)
> -{
> - int ret;
> -
> - while ((ret = ((unsigned char) tolower (*s1)
> - - (unsigned char) tolower (*s2))) == 0
> - && *s1++)
> - ++s2;
> - return ret;
> -}
> -
> static void
> do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1,
> const char *s2, int exp_result)
> {
> - size_t i, iters = INNER_LOOP_ITERS;
> + size_t i, iters = INNER_LOOP_ITERS8;
> timing_t start, stop, cur;
> int result = CALL (impl, s1, s2);
> if ((exp_result == 0 && result != 0)
> diff --git a/benchtests/bench-strncasecmp.c b/benchtests/bench-strncasecmp.c
> index 5689a22901b918cf20bc58dc5175f552604bb878..051c17d9f78b62d22b4258e7ea04cc15759e2060 100644
> --- a/benchtests/bench-strncasecmp.c
> +++ b/benchtests/bench-strncasecmp.c
> @@ -23,35 +23,14 @@
> #include "json-lib.h"
>
> typedef int (*proto_t) (const char *, const char *, size_t);
> -static int simple_strncasecmp (const char *, const char *, size_t);
>
> -IMPL (simple_strncasecmp, 0)
> IMPL (strncasecmp, 1)
>
> -static int
> -simple_strncasecmp (const char *s1, const char *s2, size_t n)
> -{
> - int ret;
> -
> - if (n == 0)
> - return 0;
> -
> - while ((ret = ((unsigned char) tolower (*s1)
> - - (unsigned char) tolower (*s2))) == 0
> - && *s1++)
> - {
> - if (--n == 0)
> - return 0;
> - ++s2;
> - }
> - return ret;
> -}
> -
> static void
> do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1,
> const char *s2, size_t n, int exp_result)
> {
> - size_t i, iters = INNER_LOOP_ITERS;
> + size_t i, iters = INNER_LOOP_ITERS8;
> timing_t start, stop, cur;
>
> TIMING_NOW (start);
>
>
prev parent reply other threads:[~2023-03-08 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 11:04 Wilco Dijkstra
2023-03-08 15:23 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d608c5-6127-a3a9-940b-3bc884ae16a3@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).