From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 7FCFA3857C4E for ; Tue, 19 Oct 2021 18:14:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FCFA3857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D31AF160068; Tue, 19 Oct 2021 11:14:08 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aHOSyGmerdze; Tue, 19 Oct 2021 11:14:08 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3CBCC160097; Tue, 19 Oct 2021 11:14:08 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K500CrreuDfn; Tue, 19 Oct 2021 11:14:08 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 16D28160068; Tue, 19 Oct 2021 11:14:08 -0700 (PDT) Message-ID: Date: Tue, 19 Oct 2021 11:14:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] regex: fix buffer read overrun in search [BZ#28470] Content-Language: en-US To: Andreas Schwab Cc: libc-alpha@sourceware.org References: <20211018221548.76024-1-eggert@cs.ucla.edu> <8735oxsct4.fsf@igel.home> <87tuhdqv48.fsf@igel.home> <87k0i9oxus.fsf@igel.home> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <87k0i9oxus.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 18:14:10 -0000 On 10/19/21 08:09, Andreas Schwab wrote: > Why is the bug not in re_string_reconstruct? Since string[match_first] > exists, so should re_string_byte_at (&mctx.input, offset). I don't know, as I lacked the time to investigate re_string_reconstruct. Although the patch I proposed fixes the test case that prompted it, possibly it is only a partial fix for a more-general problem.