From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2] math: Add math-use-builtins-fabs (BZ#29027)
Date: Tue, 5 Apr 2022 14:58:06 -0300 [thread overview]
Message-ID: <a54eca3c-285d-e7fa-e43f-41251b190edf@linaro.org> (raw)
In-Reply-To: <20220405173210.3028668-1-adhemerval.zanella@linaro.org>
On 05/04/2022 14:32, Adhemerval Zanella wrote:
> Both float, double, and _Float128 are assumed to be supported
> (float and double already only uses builtins). Only long double
> is parametrized due GCC bug 29253 which prevents its usage on
> powerpc.
>
> It allows to remove i686, ia64, x86_64, powerpc, and sparc arch
> specific implementation.
>
> On ia64 it also fixes the sNAN handling:
>
> math/test-float64x-fabs
> math/test-ldouble-fabs
>
> Checked on x86_64-linux-gnu, i686-linux-gnu, powerpc-linux-gnu,
> powerpc64-linux-gnu, sparc64-linux-gnu, and ia64-linux-gnu.
> ---
> v2: Assume _Float128 support and handle GCC bug 29253 on powerpc.
> ---
> sysdeps/generic/math-use-builtins-fabs.h | 3 +
> sysdeps/generic/math-use-builtins.h | 1 +
> sysdeps/i386/fpu/s_fabsl.S | 10 ---
> sysdeps/ia64/fpu/s_fabsl.S | 82 -------------------
> sysdeps/ieee754/ldbl-128/s_fabsl.c | 9 +-
> sysdeps/ieee754/ldbl-128ibm/s_fabsl.c | 5 ++
> .../s_fabsl.S => ieee754/ldbl-96/s_fabsl.c} | 18 ++--
> sysdeps/powerpc/fpu/math-use-builtins-fabs.h | 8 ++
> sysdeps/powerpc/powerpc32/fpu/s_fabsl.S | 52 ------------
> sysdeps/powerpc/powerpc64/fpu/s_fabsl.S | 34 --------
> sysdeps/sparc/sparc32/fpu/s_fabsl.c | 9 --
> sysdeps/sparc/sparc64/fpu/s_fabsl.c | 7 --
> 12 files changed, 30 insertions(+), 208 deletions(-)
> create mode 100644 sysdeps/generic/math-use-builtins-fabs.h
> delete mode 100644 sysdeps/i386/fpu/s_fabsl.S
> delete mode 100644 sysdeps/ia64/fpu/s_fabsl.S
> rename sysdeps/{x86_64/fpu/s_fabsl.S => ieee754/ldbl-96/s_fabsl.c} (78%)
> create mode 100644 sysdeps/powerpc/fpu/math-use-builtins-fabs.h
> delete mode 100644 sysdeps/powerpc/powerpc32/fpu/s_fabsl.S
> delete mode 100644 sysdeps/powerpc/powerpc64/fpu/s_fabsl.S
> delete mode 100644 sysdeps/sparc/sparc32/fpu/s_fabsl.c
> delete mode 100644 sysdeps/sparc/sparc64/fpu/s_fabsl.c
>
> diff --git a/sysdeps/generic/math-use-builtins-fabs.h b/sysdeps/generic/math-use-builtins-fabs.h
> new file mode 100644
> index 0000000000..ab9201c721
> --- /dev/null
> +++ b/sysdeps/generic/math-use-builtins-fabs.h
> @@ -0,0 +1,3 @@
> +/* Generic implementations already assume builtin support for
> + float, double, and _Float128. */
> +#define USE_FABSL_BUILTIN 0
Sigh... this should 1 here.
prev parent reply other threads:[~2022-04-05 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 17:32 Adhemerval Zanella
2022-04-05 17:58 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54eca3c-285d-e7fa-e43f-41251b190edf@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).