From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A292F3858C00 for ; Thu, 23 Feb 2023 18:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A292F3858C00 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=redhat.com Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVGMv-0003aE-3c for libc-alpha@gnu.org; Thu, 23 Feb 2023 13:31:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677177059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PDSNrqXIPjYgEtLGLOrgj5aj+V4nSt+qtnokZf0j9uk=; b=TAids062ArRqpm5KsEyWK3aHssbKGtoksJf3hN15vJJvITK2XiDtwDTcYivv6eKSyqLfDm Cq383UA58m7Y18h+R37kv4Vtp3HAjaAwDnyOxrXQSJ2yD7V39F/tiKyD299ZzXgU1l+fgA cRwUzlZ+QrK94wUMs2QfH7qE853g9gg= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-557-NR_cD3_bPqybwEowh4hyPA-1; Thu, 23 Feb 2023 13:30:58 -0500 X-MC-Unique: NR_cD3_bPqybwEowh4hyPA-1 Received: by mail-io1-f70.google.com with SMTP id p188-20020a6b8dc5000000b0074c96ca271bso3163980iod.0 for ; Thu, 23 Feb 2023 10:30:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PDSNrqXIPjYgEtLGLOrgj5aj+V4nSt+qtnokZf0j9uk=; b=WPc1P6/mPMQhVDNjbDDe4GX3A0N1IMouhpJpO/You1OJdGOWaCTzvIOJNIp2ryjXJp jctRdDg9OvQ07/1w6Io9ilh2ZEQroQxIqYQyzJWOJtU1PEDjEximJ7EQJLFEnWWOx0g1 1FVJdjxwEG14AKNkv5iikxHmL6A5OEn2HzBV5PZEs6y7avg0fG1MckhPOwPmLduAQx25 DB+3h9uk+3PsUg2G5lEl6LIW5DXylF7nb4VYvEityHy5t8k0EAbriwyC0aT9ppK0YLsE 71mmVZEpJuWRObBp0mTOYepN3oyn3sropohIPHi/NmAtR/kgJWnSjimtaQMrrcmvTY3g PVsQ== X-Gm-Message-State: AO0yUKWu7WP1/LwGDMLotqAo4D15aaA584mJyMsJShl0Hg4VjYbv55XR 8jzUsQMzwzi/mSjQ7oikfmcyzeKg/9uWJ9zn+/l8vMWBXqYcbIVZbLlXknE6dQKkyN0VPgjIu3h /weHiR9dJanI= X-Received: by 2002:a92:b505:0:b0:315:4738:1b04 with SMTP id f5-20020a92b505000000b0031547381b04mr10456276ile.20.1677177057388; Thu, 23 Feb 2023 10:30:57 -0800 (PST) X-Google-Smtp-Source: AK7set+LM8H6Tc8Atj7O/wiBwC4WkOFSpg2vSAwNZ0w3rWZuTRESLvywWDO+bNkIeCwq4eKzKFG5nw== X-Received: by 2002:a92:b505:0:b0:315:4738:1b04 with SMTP id f5-20020a92b505000000b0031547381b04mr10456270ile.20.1677177057134; Thu, 23 Feb 2023 10:30:57 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id j7-20020a056e02014700b00313d32f8345sm3747479ilr.66.2023.02.23.10.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 10:30:56 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 13:30:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] cdefs.h: fix "__clang_major" typo To: Adhemerval Zanella , Paul Eggert , libc-alpha@gnu.org References: <20211221221329.347210-1-eggert@cs.ucla.edu> From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=carlos@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,NICE_REPLY_A=-0.09,RCVD_IN_DNSWL_NONE=-0.0001,RCVD_IN_MSPIKE_H2=-0.001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: > > > On 21/12/2021 19:13, Paul Eggert wrote: >> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Ahemerval, In reviewing old patches to improve our SLI for patch review I noticed that this patch is reviewed and approved but not committed. The patch still looks correct to me. Would you mind committing this on behalf of Paul please? >> --- >> misc/sys/cdefs.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >> index a05b538579..f6e1db1954 100644 >> --- a/misc/sys/cdefs.h >> +++ b/misc/sys/cdefs.h >> @@ -81,7 +81,7 @@ >> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >> # else >> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >> # if __cplusplus >= 201103L >> # define __THROW noexcept (true) >> # else > -- Cheers, Carlos.