From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 9C8A43947406 for ; Tue, 13 Apr 2021 19:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C8A43947406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eggert@cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D9492160084 for ; Tue, 13 Apr 2021 12:21:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SeqjZ7OaqyN4 for ; Tue, 13 Apr 2021 12:21:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 15E3C160091 for ; Tue, 13 Apr 2021 12:21:23 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MkA8ci0em-Rm for ; Tue, 13 Apr 2021 12:21:23 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EC692160084 for ; Tue, 13 Apr 2021 12:21:22 -0700 (PDT) To: GNU C Library From: Paul Eggert Organization: UCLA Computer Science Department Subject: UTF-8 in glibc commit messages Message-ID: Date: Tue, 13 Apr 2021 12:21:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 19:21:26 -0000 Today I tried to install a glibc fix with some non-ASCII chars in the=20 commit message, but sourceware.org rejected the fix with the diagnostic=20 reproduced at the end of this email. I'm puzzled by the message, as I see that existing commit messages use=20 UTF-8, e.g., 41f013cef24884604c303435dd1915be2ea5c0e0's commit message=20 contains the phrase "Developer=E2=80=99s Manual" with the same curly apos= trophe=20 that my proposed commit used. Has something changed recently on=20 sourceware.org to reject such commits? I assume that UTF-8 is fine in commit messages as we use it to spell=20 contributors' names. I worked around this particular problem by=20 ASCIIfying the quotes but I'd rather spell people's names nicely in any=20 future patches. (It might make sense for the commit hook to rejects some=20 troublesome Unicode characters but that's a somewhat different topic.) Here's the diagnostic I got: $ git push Enumerating objects: 21, done. Counting objects: 100% (21/21), done. Delta compression using up to 4 threads Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 3.79 KiB | 242.00 KiB/s, done. Total 11 (delta 10), reused 0 (delta 0), pack-reused 0 remote: *** Invalid revision history for commit=20 371ef6b43fcb5052444c3f0e1ec09d01c5017149: remote: *** It contains characters not in the ISO-8859-15 charset. remote: *** remote: *** Below is the first line where this was detected (line 16): remote: *** | Use code font for =E2=80=98malloc=E2=80=99 instead of roman= font. remote: *** ^ remote: *** | remote: *** remote: *** Please amend the commit's revision history to remove it remote: *** and try again. remote: error: hook declined to update refs/heads/master To sourceware.org:/git/glibc.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'sourceware.org:/git/glibc.git'