From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from antelope.elm.relay.mailchannels.net (antelope.elm.relay.mailchannels.net [23.83.212.4]) by sourceware.org (Postfix) with ESMTPS id 3F4633858C1F for ; Mon, 14 Aug 2023 12:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F4633858C1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C4E6C423F6; Mon, 14 Aug 2023 12:10:12 +0000 (UTC) Received: from pdx1-sub0-mail-a303.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4919440DE9; Mon, 14 Aug 2023 12:10:12 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1692015012; a=rsa-sha256; cv=none; b=RZ2OXkCGUOEb/6Hj9JytV2eGjpaKjVb3njzevXA11KxMfGeDZnoox/v2touy0uxWNYxDtU XUSfjbQ6/BhbvAWsfpyfluc0BcGBU7LjpeQ9s+U4YbV45ZFJS/+Loye/CF+Awa7ThMSAbM qTzVRPdPRbxnjq8Go/Q4wSSI2xwLWMMbpNIBNDIUjAiTEHGSUeg6OTpLPcqGO+/E/0pQLB PrmAb8BKAS/F0HbWu9U19L1Bd9cqwqBB6NIEwAZM/MOxcDjb57WEF68VO0p1jCBK6+SjRd kskROp3GJcvXMKb18sqLDPy8U9JZZbCGAz53emgYsieK2eBc7QRROiZQT6XqNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1692015012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FuGDnCKoO5as6Dtvu/WQ2QKwnl5XCGF7VZFqrMAV9jQ=; b=DWrOXO6q79hlwqBHumjU6Dg7XEc/n6OaWFc8xD1RC1dMxd98bTTwij1ADmD83mS84xSqrC e86sokArqq3NAVls4MXKFWOMLavPXmQqm7KPT403Cyha8WXJyBOnj6eugC+UXJd/mzffhL rv1Bbti6rf9K7K1qticU7X3YNlQdfAjUcARNIGaKAD3KsLKVQVd8M50z+MhdG1TA/qaTIT 9RzhAmEK/lxxagZ7r7qrtswcPLP4y30nQFkkUm0IGDWp0YKF+Mll5z/lWyICToazwbptAx NtIzfQZDHLMbf/lGaQualf4/LtKmn76U+5JrbFoge13wzmJT9tILsdSsEWBhzg== ARC-Authentication-Results: i=1; rspamd-849d547c58-z6wt4; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Macabre-Cooing: 1e67f9503e0bb3e5_1692015012538_2616243213 X-MC-Loop-Signature: 1692015012537:2063576837 X-MC-Ingress-Time: 1692015012537 Received: from pdx1-sub0-mail-a303.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.49.134 (trex/6.9.1); Mon, 14 Aug 2023 12:10:12 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-184.dsl.bell.ca [142.113.138.184]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a303.dreamhost.com (Postfix) with ESMTPSA id 4RPYBC6dTFz60; Mon, 14 Aug 2023 05:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1692015012; bh=FuGDnCKoO5as6Dtvu/WQ2QKwnl5XCGF7VZFqrMAV9jQ=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=q+kd8rjKINKUezOFVGEenUxVUGFSTyhyEASaasNR31BB0marmvE4hyfcK2FnAk/jF ZCieSKAhE5Yo/SELWqQfBiiCNAQFEJqGyov3Im9DQlz3OPOWcvFuneo8l/nY0MQqOJ 6BzKPBSYp4zusbPkVbKpZ0NhciaKfhyXjvoWJkqjp0TJiOJN4rQg6uXgOeGFEDWKrI 63Yi1mFDenXw1FViuIEnSTi3jbTc4XSiL8sBMZ6E0xehRZXjbv7zHPrsqp6mfM0bCr YoicB3lagRcUMAyBFkjh5Re7rxVFZDGosezQsCglM0wmCD7Uj9cwSdXMwJFT5JOahX lZuyIS1x6ZQ0w== Message-ID: Date: Mon, 14 Aug 2023 08:10:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] configure: Add -Wall again to the default CFLAGS Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <87leedc07t.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <87leedc07t.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3037.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-14 07:49, Florian Weimer via Libc-alpha wrote: > Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove > --enable-all-warnings option") removed it due to a missing +. > > Tested with build-many-glibcs.py (glibcs stage only, full > compilers/glibcs test still running). Needs -Wall fixes from the recent > malloc fix. > > --- > Makeconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM. Reviewed-by: Siddhesh Poyarekar > > diff --git a/Makeconfig b/Makeconfig > index c4dd9ea8f2..c48fcc59e8 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -857,7 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd) > endif > > # Extra flags to pass to GCC. > -gccwarn := -Wall -Wwrite-strings -Wundef > ++gccwarn := -Wall -Wwrite-strings -Wundef > ifeq ($(enable-werror),yes) > +gccwarn += -Werror > endif > > base-commit: bb481eedcee19bb342b91eddc86417df660e6c56 >