* [PATCH] configure: Add -Wall again to the default CFLAGS
@ 2023-08-14 11:49 Florian Weimer
2023-08-14 12:10 ` Siddhesh Poyarekar
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2023-08-14 11:49 UTC (permalink / raw)
To: libc-alpha
Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove
--enable-all-warnings option") removed it due to a missing +.
Tested with build-many-glibcs.py (glibcs stage only, full
compilers/glibcs test still running). Needs -Wall fixes from the recent
malloc fix.
---
Makeconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makeconfig b/Makeconfig
index c4dd9ea8f2..c48fcc59e8 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -857,7 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd)
endif
# Extra flags to pass to GCC.
-gccwarn := -Wall -Wwrite-strings -Wundef
++gccwarn := -Wall -Wwrite-strings -Wundef
ifeq ($(enable-werror),yes)
+gccwarn += -Werror
endif
base-commit: bb481eedcee19bb342b91eddc86417df660e6c56
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] configure: Add -Wall again to the default CFLAGS
2023-08-14 11:49 [PATCH] configure: Add -Wall again to the default CFLAGS Florian Weimer
@ 2023-08-14 12:10 ` Siddhesh Poyarekar
2023-08-14 13:36 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Siddhesh Poyarekar @ 2023-08-14 12:10 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 2023-08-14 07:49, Florian Weimer via Libc-alpha wrote:
> Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove
> --enable-all-warnings option") removed it due to a missing +.
>
> Tested with build-many-glibcs.py (glibcs stage only, full
> compilers/glibcs test still running). Needs -Wall fixes from the recent
> malloc fix.
>
> ---
> Makeconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> diff --git a/Makeconfig b/Makeconfig
> index c4dd9ea8f2..c48fcc59e8 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -857,7 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd)
> endif
>
> # Extra flags to pass to GCC.
> -gccwarn := -Wall -Wwrite-strings -Wundef
> ++gccwarn := -Wall -Wwrite-strings -Wundef
> ifeq ($(enable-werror),yes)
> +gccwarn += -Werror
> endif
>
> base-commit: bb481eedcee19bb342b91eddc86417df660e6c56
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] configure: Add -Wall again to the default CFLAGS
2023-08-14 12:10 ` Siddhesh Poyarekar
@ 2023-08-14 13:36 ` Florian Weimer
0 siblings, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2023-08-14 13:36 UTC (permalink / raw)
To: Siddhesh Poyarekar; +Cc: libc-alpha
* Siddhesh Poyarekar:
> On 2023-08-14 07:49, Florian Weimer via Libc-alpha wrote:
>> Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove
>> --enable-all-warnings option") removed it due to a missing +.
>> Tested with build-many-glibcs.py (glibcs stage only, full
>> compilers/glibcs test still running). Needs -Wall fixes from the recent
>> malloc fix.
>> ---
>> Makeconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Thanks, I'll delay checking this in until after the latest malloc patch
is committed, which also removes the -Wall warnings that crept in.
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-14 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14 11:49 [PATCH] configure: Add -Wall again to the default CFLAGS Florian Weimer
2023-08-14 12:10 ` Siddhesh Poyarekar
2023-08-14 13:36 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).