From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id 5B662395307B for ; Thu, 8 Dec 2022 17:08:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B662395307B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-1433ef3b61fso2514858fac.10 for ; Thu, 08 Dec 2022 09:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iuKwzjQfopko2IjHcSNxcQjUf2Qs6r9qgTkrwB/mVlU=; b=nm45RJ32keMqjOOknAyvUQ7TVryRTrFsXXcpU5yD2cz0VcLnIYD8P+8v9Qwi+2unn/ RFUnFnToYiw915oJKsvbDngZW5ZhjG0EGnQ7lYwz+S32EdvM1C3h7zyKaAg2rNj4Z1tP ItpSVB7hYKVcM2hD0ui55G7FqCzBPY5lSBYoBhF3Z2wcQHgFQtZE1y2fc6YcOYCgkhs5 ODKOio7NtsSP9RfXcI5Mm+PFM01L4QiwX+q4jeTLzDCashCKvGKxIF6iZLcwsiTEnykp bB9k70PlRU91vKQJ0tdkvj2qLgHL2YPtvM+L+G9XD9Fs1wNRpgqoCq5UbYlyXFsZiAKB wf8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iuKwzjQfopko2IjHcSNxcQjUf2Qs6r9qgTkrwB/mVlU=; b=WCESKZLueG6fKdI1rXBdC0O4cgWmFVZ0+Rq8XiR0CuB35l80ZYWNq2ldOr8pi5LUz7 k5swpECSUK547QNkZZtUISDCNip5JN+INPmXbdzTRMVwMwgkyRmbDTRtc9Sb1wP/oabE dAqE98wY+OLOy2RejQ3PBDg/CjwsvLdbq6Hee6i7j0d5JLKg8e6xY1D/z8VtfY1Z5Nes RBzfZyx9Sr69GknKesDAQ3Dv1Rdo/DdTDiZ8CE27kAJn0hckSmqJnZLL//f+zmMKVlKk bs2L7bNA8BDTYMLZayFjwRZDh6OHT/Bsolqy4QQE5HP6F7y7ek2CF3MbXw00lJWG3kRF o5Rg== X-Gm-Message-State: ANoB5pnkjSJfKsay8HqJmbvnfLRMkvBk22jNMYVGyilfn/mL3nQgqOqJ NElqRwPYFciP0t4ft+QT3dDjE7fwNZCF3bUu2N0= X-Google-Smtp-Source: AA0mqf6ETJ6dFB7BL10DtEAqpcSj3Me9q5gPTo7rFt/iQgrUqOsmdlW31yXvpPsc2fjYhzeoB4wsGw== X-Received: by 2002:a05:6870:6b0c:b0:144:b58e:b508 with SMTP id mt12-20020a0568706b0c00b00144b58eb508mr7333355oab.211.1670519281653; Thu, 08 Dec 2022 09:08:01 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:6793:d83e:e871:6162:c8c0? ([2804:1b3:a7c2:6793:d83e:e871:6162:c8c0]) by smtp.gmail.com with ESMTPSA id h3-20020a9d6403000000b0066de9dc966fsm11529215otl.65.2022.12.08.09.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 09:08:01 -0800 (PST) Message-ID: Date: Thu, 8 Dec 2022 14:07:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] : Make strchrnul, strcasestr, memmem available by default Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <87h6yo4e3v.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87h6yo4e3v.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24/11/22 11:32, Florian Weimer via Libc-alpha wrote: > FreeBSD makes them available by default, too, so there does not seem > to be a reason to restrict these functions to _GNU_SOURCE. > > Tested on x86_64-linux-gnu. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > string/string.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/string/string.h b/string/string.h > index 54dd8344de..bfeeeb2eb4 100644 > --- a/string/string.h > +++ b/string/string.h > @@ -274,7 +274,7 @@ extern char *strrchr (const char *__s, int __c) > __THROW __attribute_pure__ __nonnull ((1)); > #endif > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > /* This function is similar to `strchr'. But it returns a pointer to > the closing NUL byte in case C is not found in S. */ > # ifdef __CORRECT_ISO_CPP_STRING_H_PROTO > @@ -368,7 +368,7 @@ extern char *strtok_r (char *__restrict __s, const char *__restrict __delim, > __THROW __nonnull ((2, 3)); > #endif > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > /* Similar to `strstr' but this function ignores the case of both strings. */ > # ifdef __CORRECT_ISO_CPP_STRING_H_PROTO > extern "C++" char *strcasestr (char *__haystack, const char *__needle) > @@ -382,7 +382,7 @@ extern char *strcasestr (const char *__haystack, const char *__needle) > # endif > #endif > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > /* Find the first occurrence of NEEDLE in HAYSTACK. > NEEDLE is NEEDLELEN bytes long; > HAYSTACK is HAYSTACKLEN bytes long. */ > > base-commit: a46956e65d037358161e7512a9f0fd408ea1333a >