From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mail@nh2.me>
Received: from mail.nh2.me (mail.nh2.me [116.202.188.98])
 by sourceware.org (Postfix) with ESMTPS id B8AD73858436
 for <libc-alpha@sourceware.org>; Sat, 30 Oct 2021 00:37:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8AD73858436
Subject: Re: [PATCH] malloc_stats(): Fix `unsigned int` overflow
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
References: <xn35oja9w2.fsf@greed.delorie.com>
From: =?UTF-8?Q?Niklas_Hamb=c3=bcchen?= <mail@nh2.me>
Message-ID: <a646adce-08a5-6574-457a-a8f860b9d808@nh2.me>
Date: Sat, 30 Oct 2021 02:36:58 +0200
MIME-Version: 1.0
In-Reply-To: <xn35oja9w2.fsf@greed.delorie.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_INFOUSMEBIZ, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Oct 2021 00:37:04 -0000

The error:

> malloc.c:5169:48: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]

glibc doesn't require C99, so I guess "%zu" is not an option, right?

Since this is just in an `fprintf`, would casting to `(unsigned long long)` and using "%llu" be considered acceptable?

Niklas