From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id D3D6A3858D39 for ; Tue, 28 Mar 2023 13:33:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3D6A3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x333.google.com with SMTP id a30-20020a9d3e1e000000b006a13f728172so3178399otd.3 for ; Tue, 28 Mar 2023 06:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680010428; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HU1JM7R8RyCxMBIQNLeR0Ftn7fmvbQwyyA+fPZp0wBc=; b=jAObHQWsomFSRPVgGcXLdUY/PQ5+Dw66ItP8iV3spavKFuLIv6dSEACFUJnbh0iG0P 20qrlcBW5Ji3skrT+V6XfUFjFig6OwKZQj/1d0qKhGNhtdwu6daq/tFqrHmoFNe1esiZ TVU4J2ste+WcuXbHxKXSw1EtENYTHs8De73ObI9i0jgmeN9SWL+a3XkJuC0ku2NQxAQj Y9ym61F+4UsabTzKyI43wumqJcwVw2US/u7wj87P+u+rDzoZjRe55Oaf8no1CtEhvbdt oIWd353C0xyavOD9hkAXiJfHpmUlbXFeIbHUSdpoqvqyOHTEy5BfWHysdzmvD1Y6lZQ2 loVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680010428; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HU1JM7R8RyCxMBIQNLeR0Ftn7fmvbQwyyA+fPZp0wBc=; b=p7DbYLXpWEGOGjUG0wdHUNvtC1roDh/DcfNXz+cNecJfNqfdjEJy0zhZlrKuGVtnl7 6rIZEMuj5gV4AW2NZqzuHJLMS8Aag+x4tpUexKZeQks19TjRIYHv6fdIcsDqx43pVeXL ijmoxqxPZwUIUbekIa1GwuFIOB92dCH+fwyNGMzyjlWr7+zZ+ZtcuP3X5BcLFCnjo6a/ wyjkoLlvVlDDrpqE9AFZt7fkPU2rdBZhp/Z2yDGagbO+AKWX65YTtyVCb2/vpbi+z8E6 vi9CGdMF5aEcZq9iuwfythoS9q063P8I8Y43qGuLCwcJCuVrylymumJOiJiFeAhK8uLm FGrw== X-Gm-Message-State: AO0yUKWpJy8/GDCZ38Huj7NvoIl+PKNrqKmXya/gptdw0ZeqC/wX9uiZ aDNjprS2uT2lbupaCo5uUL4hVq8xBXyfbu6ri9pQyw== X-Google-Smtp-Source: AK7set+/F1uB5/vR3eaeocw/xs+YREShItFoJuFBsHeJOFvBXaFc6YpN29hGi0BpJIqPhNVxkbqFIA== X-Received: by 2002:a9d:6385:0:b0:69f:a487:d7c2 with SMTP id w5-20020a9d6385000000b0069fa487d7c2mr7753119otk.1.1680010427931; Tue, 28 Mar 2023 06:33:47 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:60f9:1426:1d2d:d6b:1761? ([2804:1b3:a7c1:60f9:1426:1d2d:d6b:1761]) by smtp.gmail.com with ESMTPSA id x13-20020a056830114d00b0069dc250cb24sm7310329otq.3.2023.03.28.06.33.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 06:33:47 -0700 (PDT) Message-ID: Date: Tue, 28 Mar 2023 10:33:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH glibc] Allow building with --disable-nscd again. Content-Language: en-US To: libc-alpha@sourceware.org References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/03/23 18:04, Flavio Cruz via Libc-alpha wrote: > The change 88677348b4de breaks the build with undefiend references to > the NSCD functions. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > malloc/set-freeres.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/malloc/set-freeres.c b/malloc/set-freeres.c > index f452ff838b..42d70d3971 100644 > --- a/malloc/set-freeres.c > +++ b/malloc/set-freeres.c > @@ -37,11 +37,13 @@ > # pragma weak __intl_freemem > # pragma weak __libio_freemem > # pragma weak __libc_fstab_freemem > +#ifdef USE_NSCD > # pragma weak __nscd_gr_map_freemem > # pragma weak __nscd_hst_map_freemem > # pragma weak __nscd_pw_map_freemem > # pragma weak __nscd_serv_map_freemem > # pragma weak __nscd_group_map_freemem > +#endif > # pragma weak __libc_regcomp_freemem > # pragma weak __libc_atfork_freemem > # pragma weak __res_thread_freeres > @@ -95,11 +97,15 @@ __libc_freeres (void) > call_function_static_weak (__intl_freemem); > call_function_static_weak (__libio_freemem); > call_function_static_weak (__libc_fstab_freemem); > + > +#ifdef USE_NSCD > call_function_static_weak (__nscd_gr_map_freemem); > call_function_static_weak (__nscd_hst_map_freemem); > call_function_static_weak (__nscd_pw_map_freemem); > call_function_static_weak (__nscd_serv_map_freemem); > call_function_static_weak (__nscd_group_map_freemem); > +#endif > + > call_function_static_weak (__libc_regcomp_freemem); > call_function_static_weak (__libc_atfork_freemem); > /* __res_thread_freeres deallocates the per-thread resolv_context);