From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id C57FD385840A for ; Mon, 13 Mar 2023 17:10:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C57FD385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32f.google.com with SMTP id q11-20020a056830440b00b00693c1a62101so7138578otv.0 for ; Mon, 13 Mar 2023 10:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678727434; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+nGENPNdEdZIANSks/GfsUbT0w+kXx+mPrQcRxmXXiM=; b=P5TX7GYSncpd5CioXoKh+K/zjron8ZmagtxhgxqGyW7UzLupIaVNxTXuqb2FbOg9Qt WtXQeZQLsjzI3/rdnylUt33hhQxFveiXCJ+igJK1IQXokBfebrfxIj+agXoWC+GV8LZ3 FZ3wZHCesg6X4eIfEK51rJQkvGQ5MW31+Cu7QDt6GteoPaOsPha+wCf2B/gUvS8ovjAE /EDwr0IMlUzvdyXUniZKIVaq5C5kkyFcx+3FIWJSMlUprGl0ERcjaSEosZIdifaFJS8K 0uTbsoedPRz7tYU8TSNlFhImScHV9W6YIddGe2fr/H1OxdbCgwvHORp/1s8nq0LllDhn h7YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678727434; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+nGENPNdEdZIANSks/GfsUbT0w+kXx+mPrQcRxmXXiM=; b=lhaG86HCcG/h/q4Kzd2/GPNH06ZPXL6QpEW7g+HprOxA7i6dd+/ojuA6iRKoks6hsA Hw5wMtPD/lfK+6PlHLj7iSYOem+cXG6t2/byVkij1ZJIRvg72PUoNkle4XCgTiexRV/D hwg430+MDd0UUKIQV9xkN8nmyT7kUN2k5XgdQ8hsMxdepJ5CmQzLRNg1YtrBz3ZiYnho 8xkYOTQeZ0qiFJbgAp3E0750bJVtoe+mvON23eC72/KwkAyrGDfcQIkd2HInyhisJzrd SY42jX0pyCXOUwkYAnlvpEg9gPuG5hUxotlHxXIryknW1lU6DIkBeZy/PwqYFTORj6jJ jmLQ== X-Gm-Message-State: AO0yUKW2T3v0QQ7Azi3ubyDahUXZ0xCxoyqlHZ61bq4Kw3zyrC/YJowc mMmePtTUmB1zNAIHVy/iv+Pg6RCkpQSsR5Xk0xkkTg== X-Google-Smtp-Source: AK7set/YCGfUKWKCW3eHaYPDUv96FHV8P2NliCzBLifFbjUBOTAx07PSmhbX94iT1zxvu3OYw4jbPg== X-Received: by 2002:a05:6830:43a1:b0:690:e7d0:7918 with SMTP id s33-20020a05683043a100b00690e7d07918mr22690671otv.8.1678727434024; Mon, 13 Mar 2023 10:10:34 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:544b:c5ae:2fda:455d:6e31? ([2804:1b3:a7c0:544b:c5ae:2fda:455d:6e31]) by smtp.gmail.com with ESMTPSA id a23-20020a9d3e17000000b0068abc8e786fsm197226otd.10.2023.03.13.10.10.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 10:10:33 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 14:10:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] time: Fix strftime(3) API regarding nullability Content-Language: en-US To: Alejandro Colomar , libc-alpha@sourceware.org Cc: Alejandro Colomar , Paul Eggert References: <20230312000810.51652-1-alx@kernel.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230312000810.51652-1-alx@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/03/23 21:08, Alejandro Colomar via Libc-alpha wrote: > strftime(3) doesn't accept null pointers in any of the parameters. > > Cc: Paul Eggert > Signed-off-by: Alejandro Colomar LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > time/time.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/time/time.h b/time/time.h > index d18089116e..28fb075b19 100644 > --- a/time/time.h > +++ b/time/time.h > @@ -99,7 +99,8 @@ extern time_t __REDIRECT_NTH (mktime, (struct tm *__tp), __mktime64); > of characters written, or 0 if it would exceed MAXSIZE. */ > extern size_t strftime (char *__restrict __s, size_t __maxsize, > const char *__restrict __format, > - const struct tm *__restrict __tp) __THROW; > + const struct tm *__restrict __tp) > + __THROW __nonnull((1, 3, 4)); > > #ifdef __USE_XOPEN > /* Parse S according to FORMAT and store binary time information in TP.