From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id F189D3858C55 for ; Mon, 25 Jul 2022 13:27:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F189D3858C55 Received: by mail-ot1-x329.google.com with SMTP id g20-20020a9d6a14000000b0061c84e679f5so8639213otn.2 for ; Mon, 25 Jul 2022 06:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=qAqd/o9iZH1mnvhFAYKeJ66maaosJ4K7kMMqAOt5I38=; b=skSYFYgTCux9jL3X2w1QTbosR4KvZEr7sLXTw09kvci4xsEJCUeFoYQZIr3DzagLHY nfVC0QyTHwmVb2ZitZlGcwiq5TQ67VrsIEifDm1au0GPvCg73FlcroSojEd3OQD5/dQG Wxc1q76waJUwmbsKJhlPn7o/pwEShkNDjCmEuSx6J6jl8pwb5J6WlV/Fpuej1sjdvB2M F4Lo9y839nuMylepQGG3R7+wDJv0uHmi/LUe4ZEBuRdd3TkwKowMjcKNHuoigR+3Ev5q 9cVR9DRth21NGxbpLuZtGyQgvgxq+V/CSlYO8t4MZNlyFzgz8gJUay/lx3+0pHEYwaNv XZsQ== X-Gm-Message-State: AJIora/z4wN7hxK6/BnkNL/XgsNSfNWoU5fK639JfryvMfdGWN5UqVZI Qo08sB0osERe8/mnW+63lXLEdg== X-Google-Smtp-Source: AGRyM1tuG4rh47cDF7c4Gxjh1XwHKBX4bDm+DZHPp2eCTY4CyptMbZq8r0uXjnXZjbpoM/JhyE71Cg== X-Received: by 2002:a9d:686:0:b0:61c:8be0:a26a with SMTP id 6-20020a9d0686000000b0061c8be0a26amr4639633otx.127.1658755673174; Mon, 25 Jul 2022 06:27:53 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:8ded:894b:344:2c82:9bb5? ([2804:431:c7cb:8ded:894b:344:2c82:9bb5]) by smtp.gmail.com with ESMTPSA id c17-20020a056870b29100b000e686d1386dsm6086136oao.7.2022.07.25.06.27.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jul 2022 06:27:52 -0700 (PDT) Message-ID: Date: Mon, 25 Jul 2022 10:27:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES Content-Language: en-US To: WANG Xuerui , caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com References: <20220719012056.1461897-1-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 13:27:56 -0000 On 24/07/22 06:49, WANG Xuerui wrote: > Hi, > > On 7/19/22 09:20, caiyinyu wrote: >> >> 6. Test result: all passed (ifunc disable). >> >> Test with: >>    Linux-5.19-rc4, Binutils-2.38, and GCC-12.1. >>    glibc: https://github.com/loongson/glibc/tree/loongarch_2_36_upstream_v7 >> >> Result (ifunc disable): >> XPASS: conform/UNIX98/ndbm.h/linknamespace >> XPASS: conform/XOPEN2K/ndbm.h/linknamespace >> XPASS: conform/XOPEN2K8/ndbm.h/linknamespace >> XPASS: conform/XPG42/ndbm.h/linknamespace >> UNSUPPORTED: crypt/cert >> UNSUPPORTED: elf/tst-env-setuid >> UNSUPPORTED: elf/tst-env-setuid-tunables >> XPASS: elf/tst-protected1a >> XPASS: elf/tst-protected1b >> UNSUPPORTED: elf/tst-valgrind-smoke >> UNSUPPORTED: misc/tst-adjtimex >> UNSUPPORTED: misc/tst-clock_adjtime >> UNSUPPORTED: misc/tst-ntp_adjtime >> UNSUPPORTED: misc/tst-pkey >> UNSUPPORTED: misc/tst-rseq >> UNSUPPORTED: misc/tst-rseq-disable >> UNSUPPORTED: nptl/test-cond-printers >> UNSUPPORTED: nptl/test-condattr-printers >> UNSUPPORTED: nptl/test-mutex-printers >> UNSUPPORTED: nptl/test-mutexattr-printers >> UNSUPPORTED: nptl/test-rwlock-printers >> UNSUPPORTED: nptl/test-rwlockattr-printers >> UNSUPPORTED: nptl/tst-pthread-gdb-attach >> UNSUPPORTED: nptl/tst-pthread-gdb-attach-static >> UNSUPPORTED: nptl/tst-rseq-nptl >> UNSUPPORTED: stdlib/tst-secure-getenv >> UNSUPPORTED: time/tst-clock_settime >> UNSUPPORTED: time/tst-settimeofday >> Summary of test results: >>     4535 PASS >>       22 UNSUPPORTED >>       12 XFAIL >>        6 XPASS > > Thanks for your effort these days. I ran the test on Gentoo and this is what I have found out: > > UNSUPPORTED: crypt/cert > FAIL: elf/check-abi-libc > FAIL: elf/ifuncmain1 > FAIL: elf/ifuncmain1pic > FAIL: elf/ifuncmain1pie > FAIL: elf/ifuncmain1staticpic > FAIL: elf/ifuncmain1staticpie > FAIL: elf/ifuncmain1vis > FAIL: elf/ifuncmain1vispic > FAIL: elf/ifuncmain1vispie > FAIL: elf/ifuncmain2 > FAIL: elf/ifuncmain2pic > FAIL: elf/ifuncmain3 > FAIL: elf/ifuncmain4 > FAIL: elf/ifuncmain5staticpic > FAIL: elf/ifuncmain6pie > FAIL: elf/ifuncmain7 > FAIL: elf/ifuncmain7pic > FAIL: elf/ifuncmain7pie > FAIL: elf/ifuncmain9 > FAIL: elf/ifuncmain9pic > FAIL: elf/ifuncmain9pie > UNSUPPORTED: elf/tst-env-setuid > UNSUPPORTED: elf/tst-env-setuid-tunables > FAIL: elf/tst-glibc-hwcaps-prepend-cache > FAIL: elf/tst-ifunc-textrel > FAIL: elf/tst-ldconfig-ld_so_conf-update > XPASS: elf/tst-protected1a > XPASS: elf/tst-protected1b > UNSUPPORTED: elf/tst-valgrind-smoke > FAIL: malloc/tst-free-errno-malloc-hugetlb1 > UNSUPPORTED: misc/tst-adjtimex > UNSUPPORTED: misc/tst-clock_adjtime > UNSUPPORTED: misc/tst-ntp_adjtime > UNSUPPORTED: misc/tst-pkey > UNSUPPORTED: misc/tst-rseq > UNSUPPORTED: misc/tst-rseq-disable > FAIL: nptl/tst-pthread-gdb-attach > FAIL: nptl/tst-pthread-gdb-attach-static > UNSUPPORTED: nptl/tst-rseq-nptl > FAIL: nss/tst-nss-files-hosts-long > UNSUPPORTED: resolv/tst-resolv-ai_idn > UNSUPPORTED: resolv/tst-resolv-ai_idn-latin1 > UNSUPPORTED: stdlib/tst-secure-getenv > UNSUPPORTED: time/tst-clock_settime > UNSUPPORTED: time/tst-settimeofday > > Of these, the ifunc failures are "expected" by you, the elf/check-abi-libc diff is trivial (maybe you just didn't rebase as frequently): > > --- ../sysdeps/unix/sysv/linux/loongarch/lp64/libc.abilist 2022-07-23 14:45:57.490029442 +0800 > +++ /home/xenon/src/glibc/build/libc.symlist    2022-07-24 13:44:10.416642655 +0800 > @@ -496 +496 @@ GLIBC_2.36 _mcount F > -GLIBC_2.36 _nl_default_dirname D 0x12 > +GLIBC_2.36 _nl_default_dirname D 0x17 > @@ -541,0 +542,3 @@ GLIBC_2.36 alphasort64 F > +GLIBC_2.36 arc4random F > +GLIBC_2.36 arc4random_buf F > +GLIBC_2.36 arc4random_uniform F > > The others may need some love. Of course they're possibly because of my particular environment (Gentoo is a little bit different than "ordinary" distros like Debian/Fedora, and I already have to symlink the libgcc_s.so and libstdc++.so to pass the nptl tests at all). The 'elf/tst-glibc-hwcaps-prepend-cache' and 'elf/tst-ldconfig-ld_so_conf-update', might worth to take a look, although they are not arch-specific and I think it is more related to the test environment. Also, once you add the loongarch entry on release wiki [2], please the configure options use to state ifunc needs to be explicit disabled. > > Coming to code quality, there are obviously warts present, like the lingering uses of the name "x" for $r21 and apparent lack of assembly pseudo-insn sugar usages (e.g. no "move a, b" but always "or a, b, zero"; the code must be directly descended from an extremely early time when the assembler didn't have such support), but at this point these cosmetic concerns are better fixed after 2.36 to minimize churn prior to release. At a quick glance the ABI is looking good. (There is a certain "__x" in bits/setjmp.h meant to refer to r21, but __jmp_buf is not public API so I think we're safe here.) > I agree that cosmetic issues should not interfere with loongarch64 addition, we can backport if required (although for such changes I also do not see much point). I have create a branch which I think it is suitable for inclusion [1], I have fixed the ABI issue due arc4random addition and some style issues (trailing lines) that were triggering our pre-commit hooks.. > > I guess a v8 is better because the 17th patch (NEWS) needs a rebase > anyway. But let's wait for Adhemerval's suggestion... It is up to your, if you are ok with my fixed branch I can install otherwise you send a v8. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/loongarch64 [2] https://sourceware.org/glibc/wiki/Release/2.36