From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 3AE393858406 for ; Wed, 10 Aug 2022 14:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AE393858406 Received: by mail-vs1-xe2c.google.com with SMTP id q15so15453471vsr.0 for ; Wed, 10 Aug 2022 07:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=vQ3gDtwdhCVfWO6EsW7AAAX4N8PCJw7ZR8MT/9qVoSw=; b=F3+AxiIuwd/kNC07EsSquFclp9Bua5T9QLAOYlpk9xyLLFHmmm6jhgJobRc6SoLZ3s GWFd1FKkx5EqlkZi0boHFVuZB/f+/prJsf1uSBH3rKGfV7wGx62IOuto83EpBaxMf5E/ L80h5vKS88cLABCGlcgHYb5OpWzu/J1yvCE4yKn7HCYuSiV1CovCzR3Ns03cDNjaPNi4 c5ZEZ3puLBwjGbvasiPc++/H2fMR0L21AOXqDkSsP/dfXJhFUvxeZhgrFUG3A66GsgLG Cqq1kuuFsxxaYen8OlhJI2Qt9IKSGzr3piDCwV315pUFCGggHMh3DuB2OhIRkWh9SQ2v leGA== X-Gm-Message-State: ACgBeo19ffJ3AXED6r6syVEwaZCBBxj49TDMfWGCiMmwmRITAIhAf+9g Bh7jGWKzlAWEkMB6hgDRigYa1genvNtfsA== X-Google-Smtp-Source: AA6agR7MawdSiy9H7HBblEV77ZDOn0ge6BJr2U8fnzxdzF9zhsNqbuCQgpSOey3I/LbhOM32LghP6w== X-Received: by 2002:a05:6102:e42:b0:36f:94fa:5ede with SMTP id p2-20020a0561020e4200b0036f94fa5edemr11551712vst.47.1660143167528; Wed, 10 Aug 2022 07:52:47 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:930b:c8c3:715b:6901:2e81? ([2804:431:c7ca:930b:c8c3:715b:6901:2e81]) by smtp.gmail.com with ESMTPSA id t24-20020ab06998000000b00384cd1abe50sm13603676uaq.32.2022.08.10.07.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 07:52:47 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 11:52:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH] linux: Make tst-mount-consts unsupported for kernels headers older than 5.0 Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20220809172215.593850-1-adhemerval.zanella@linaro.org> <875yj0fods.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <875yj0fods.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 14:52:50 -0000 On 10/08/22 06:18, Florian Weimer wrote: > * Adhemerval Zanella: > >> The linux/mount.h is only provided by Linux 5.0. >> >> Checked on x86_64-linux-gnu. >> --- >> sysdeps/unix/sysv/linux/tst-mount-consts.py | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py >> index 4fb356310b..0f5b982430 100755 >> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py >> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py >> @@ -34,6 +34,9 @@ def main(): >> args = parser.parse_args() >> >> linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc) >> + # Linux started to provide mount.h with 5.0. >> + if linux_version_headers < (5, 0): >> + sys.exit (77) >> # Constants in glibc were updated to match Linux v5.19. When glibc >> # constants are updated this value should be updated to match the >> # released kernel version from which the constants were taken. > > Should this use compile_c_snippet from the other patch? It is strategy already used on tst-pidfd-consts.py. Not sure if syscalls backport to old releases is that common (it seems that we recently had to handle it for memfd_secret), but we do not usually take this in consideration on the __ASSUME macros and optimizations.