From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91005-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 53664 invoked by alias); 13 Mar 2018 12:43:22 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 53650 invoked by uid 89); 13 Mar 2018 12:43:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Subject: Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as
 __v*printf_internal.
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
References: <20180307193205.4751-1-zackw@panix.com>
 <20180307193205.4751-7-zackw@panix.com>
 <697f02d0-e414-ac84-04c8-79530276f2dc@redhat.com>
 <CAKCAbMiRSZxBfF9_At0afOab95hVnqo22AsTFr24WgaxDzrU4g@mail.gmail.com>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <a6efad82-c313-1e5d-eae9-80eb5039687a@redhat.com>
Date: Tue, 13 Mar 2018 12:43:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAKCAbMiRSZxBfF9_At0afOab95hVnqo22AsTFr24WgaxDzrU4g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-03/txt/msg00312.txt.bz2

On 03/13/2018 01:39 PM, Zack Weinberg wrote:
> On Tue, Mar 13, 2018 at 7:59 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 03/07/2018 08:32 PM, Zack Weinberg wrote:
>>
>>> +/* __vsyslog_internal uses the same mode_flags bits as
>>> +   __v*printf_internal; see libio/libioP.h.  */
>>> +extern void __vsyslog_internal (int pri, const char *fmt, __gnuc_va_list
>>> ap,
>>> +                                unsigned int mode_flags)
>>> +     __attribute__ ((__format__ (__printf__, 2, 0)));
>>
>>
>> I'm surprised that this doesn't need attribute_hidden or libc_hidden_proto
>> to avoid new PLT calls.
> 
> That's only needed for functions that will be called _both_ from
> inside and outside glibc.  This function is only ever called from
> inside glibc, so it doesn't appear in any Versions files and it's
> hidden by default.

Some architectures will still use indirect calls without 
attribute_hidden, so please add it.  The existing tests do not catch 
this reliably unfortunately.

Thanks,
Florian