From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.cs.ucla.edu (mail.cs.ucla.edu [131.179.128.66]) by sourceware.org (Postfix) with ESMTPS id EE3273858C66 for ; Wed, 7 Feb 2024 22:56:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE3273858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE3273858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=131.179.128.66 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707346598; cv=none; b=QoC7jFJIngK4kNGH/Fc5FwmVhlqBVEE/DJyZ2paxdV9qj+zJ8POaK/h9ozN5xCv/nSL44Bp9t9TpO6eocDFP6AqsORxlCseOzCdEt6c7rugG58hPb2//KWpyu5PDInk7iHJiKgaTgxSvVU2EorhynDri/z3Qw7VU1F5OR5WMoz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707346598; c=relaxed/simple; bh=QJrYD8CWd/uFlQiCGDi9wwyS/8gqiHJBzdMhkOp/lzw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AzLu6bE710r54WGpqdRf58VscPPMyrg5Zc+0+3QswmfoLMplFIM4HWe2cRYaW8h/1MvNvCMfBHRJqBVe7P7dCzk8Co7gNBKZjDkV3g/ETBFpJIRirk3i1aHN7m+iH2hiaz+hueXdVeDHKLU/n/mXv8XNJkQr5N+fCAnGo5f2EJ0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id DCCB73C011BC5; Wed, 7 Feb 2024 14:56:32 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id Jw2P4v5mY1Hv; Wed, 7 Feb 2024 14:56:32 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8B7A83C011BD4; Wed, 7 Feb 2024 14:56:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 8B7A83C011BD4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1707346592; bh=4yfRTPhEpAka7cY1JO/PVb/uhhnwAqzdvQPubobkLGk=; h=Message-ID:Date:MIME-Version:To:From; b=p7NtjVHg+p3tYZrmyT40MxnxMDd/xRIiHvacSNaXpkdg5l8lvgNyBD9RGzjqZBzbL Ufdls23ZmyMO22YQX7OAcRF67vS0i4XDMQrbP/q/CFJ90+lyEyZqrKAeuy6X5DH6T+ 1giANTKNP8MJ4MY+Leh6Lx5kg4C17MO/4wrjsYz5gtAQrmez6uyneRtaYxFKyFESxX LbbZtpe4sklfxke4iHX7pcGQODrUwUjlqlHsmkajlS5CUSFVTsWP2PWtnKNhoFH9MI 4j+9lHl42hKU5U98xGG773JCS4T7/VCN/fnFN+vbKB78+YvbhapvRD4p4Isnqf7kcZ g6XiW5SHDabfw== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id TJoTduqi49J5; Wed, 7 Feb 2024 14:56:32 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 4E15F3C011BC5; Wed, 7 Feb 2024 14:56:32 -0800 (PST) Message-ID: Date: Wed, 7 Feb 2024 14:56:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: New GNU C Library (glibc) security flaw reported on 30 Jan 2024 Content-Language: en-US To: Zack Weinberg , Alexander Monakov Cc: Siddhesh Poyarekar , Vincent Lefevre , Xi Ruoyao , Adhemerval Zanella , Turritopsis Dohrnii Teo En Ming , GNU libc development , "ceo@teo-en-ming-corp.com" References: <20240131145555.GB2102@cventin.lip.ens-lyon.fr> <96521764f4636c9ea3f3089f369975c12fa8be77.camel@xry111.site> <20240201005155.GF3044@qaa.vinc17.org> <20240201090721.GH3044@qaa.vinc17.org> <5ea9eabb-f047-490f-abe9-43630d79c395@cs.ucla.edu> <7234533a-c8dd-4114-aa64-d4af3b138a3a@gotplt.org> <4d94a528-fe3f-413d-afa0-91a41f8371ff@app.fastmail.com> <4963e3ae-b0d5-d1d7-a986-5709d7a30bbb@ispras.ru> <30c30ef6-7446-46f6-a502-d1c623762121@app.fastmail.com> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <30c30ef6-7446-46f6-a502-d1c623762121@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/7/24 12:45, Zack Weinberg wrote: >> (Glibc VCS briefly carried an implementation with such a mistake around 2002 >> when Roger Sayle's "Towers of Hanoi merge sort" was applied and then reverted) > Was it reverted because of this mistake? Do you happen to remember what broke? As I vaguely recall, no user programs broke. I spotted the failure to conform to the C standard while reviewing qsort.c, and sent in a fix. Ulrich Drepper then found that my fix was incomplete, and fixed msort.c in a similar way. I'm relying mostly on memory here - I don't have easy access to my old mail archive at my then-employer.