From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=p1SR=6L=xry111.site=xry111@sourceware.org>
Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1])
	by sourceware.org (Postfix) with ESMTPS id 23B103858D35
	for <libc-alpha@sourceware.org>; Wed, 15 Feb 2023 14:22:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23B103858D35
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site;
	s=default; t=1676470956;
	bh=Hfmlc2Bn9fsXw9NlG1+DFeCo/7rkrc9jjneKMz7dYSA=;
	h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
	b=RlC36KQn4r95U6QjKp2Sh0zo4+w/EFe98C/Lgp/SmMO1sBSZ3Dq6chXeuSHstLLW4
	 n0M9UFLhsb3lp8ikkuHFRAd+OB07G3wIvz4V0ctDygAFFGDUEiTpqMPvoa6G3l9jHA
	 Sfemu5cjh151OELidK52j+bFxjUJT1+CgFgxJAFM=
Received: from [IPv6:240e:358:111b:f00:dc73:854d:832e:3] (unknown [IPv6:240e:358:111b:f00:dc73:854d:832e:3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384)
	(Client did not present a certificate)
	(Authenticated sender: xry111@xry111.site)
	by xry111.site (Postfix) with ESMTPSA id 62DBD65AFD;
	Wed, 15 Feb 2023 09:22:34 -0500 (EST)
Message-ID: <a75c8cc124e637bbc527e43abb9d964f22942814.camel@xry111.site>
Subject: Re: [PATCH] LoongArch: Add math-barriers.h
From: Xi Ruoyao <xry111@xry111.site>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>, 
	libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>, Wang Xuerui <i@xen0n.name>
Date: Wed, 15 Feb 2023 22:22:27 +0800
In-Reply-To: <617e860d-9bf3-ddc0-8791-655e611ad7ac@linaro.org>
References: <20230214085713.44338-1-xry111@xry111.site>
	 <617e860d-9bf3-ddc0-8791-655e611ad7ac@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 
MIME-Version: 1.0
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Wed, 2023-02-15 at 10:47 -0300, Adhemerval Zanella Netto wrote:
> On 14/02/23 05:57, Xi Ruoyao via Libc-alpha wrote:
> > This patch implements the LoongArch specific math barriers in order to =
omit
> > the store and load from stack if possible.
>=20
> LGTM, I have not see any regression with qemu.=C2=A0 As a side note, math=
/test-fenv
> shows a failure so you might take a look, you might need to update ULPs a=
s well.

Hmm, on a real hardware I saw no failures even with GCC 13 trunk (some
aggressive FVRP optimization has been added into GCC 13). But maybe
things have been changed since my last test.  I'll test again.

> Reviewed-by: Adhemerval Zanella=C2=A0 <adhemerval.zanella@linaro.org>

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University