From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74704-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 83021 invoked by alias); 14 Nov 2016 12:57:02 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 82936 invoked by uid 89); 14 Nov 2016 12:57:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Adhemerval, Hx-languages-length:426
X-HELO: mail-ua0-f176.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:cc:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=gqx3Nx+QxCEgVZ0Z5QCjzzZXpXQfpgvD3Z0W1YJMVjI=;
        b=cp6GrN7uyBqGNoEzbnufzwJaqHwym2JuPz5/YACisACMUQZ5Hj8jNmAMDW6Yd+rt9W
         5tm4MuABiDFjc+xqJJlRkCLp8ZUl3Ad+oEwlXZa5GIh1kj4LnhnR1Hu9sWVCnlNdTdzD
         nZBlb+yWI+MDWaxZIKc1Y3Q4TqGWZNJoJ8qOqzevRsYgLKKDHZITF8uUzZ2fsAfh0g/C
         53b+XYKcQHijv4vy5nNRj141n5+3nORnSKmIKCBnb/P9gTe7D5cyppan3Wp4LCE0Khhm
         Wjd3WfJegam4zmZhL390rVjz47qPmOPZCDhXyVsTR/Ww6FcBxG+3sgL4cOBvyvuda6OV
         w+Uw==
X-Gm-Message-State: ABUngvdeqjCIYCJl760awJlnnICiMVv/qSqkRzLHnlAcEHquqCUuD0bj0lglVs4PfjdmhvkY
X-Received: by 10.159.39.133 with SMTP id b5mr9817074uab.86.1479128209985;
        Mon, 14 Nov 2016 04:56:49 -0800 (PST)
Subject: Re: [PATCH] Improve strtok(_r) performance
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
 "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
References: <AM5PR0802MB2610F3F2F9864ECF0089F9E583AD0@AM5PR0802MB2610.eurprd08.prod.outlook.com>
 <AM5PR0802MB261081079A9A4BC050B185E483BC0@AM5PR0802MB2610.eurprd08.prod.outlook.com>
 <fa025578-1b1e-35b0-6477-fc109fa62e67@linaro.org>
 <AM5PR0802MB26108ACD41E28FA333134D5C83BC0@AM5PR0802MB2610.eurprd08.prod.outlook.com>
Cc: nd <nd@arm.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <a7640d6e-465f-2cf9-009e-6b767a24b1a3@linaro.org>
Date: Mon, 14 Nov 2016 12:57:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <AM5PR0802MB26108ACD41E28FA333134D5C83BC0@AM5PR0802MB2610.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00457.txt.bz2



On 14/11/2016 10:50, Wilco Dijkstra wrote:
> Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>> Why not aim for simplicity and just use strtok_r and strtok? I should
>> be a tail call in most architecture and performance loss should be
>> minimum.
> 
> You mean avoiding the duplication of code? Say inlining or tailcalling
> strtok_r in string/strtok_r.c?
> 
> Wilco

Yes.