From: Xi Ruoyao <xry111@mengyan1223.wang>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: [PATCH v2] mips: increase stack alignment in clone to match the ABI
Date: Fri, 13 Aug 2021 20:04:09 +0800 [thread overview]
Message-ID: <a7a3dc2e7a8ea4ba455614ecd8190adc05790c61.camel@mengyan1223.wang> (raw)
In-Reply-To: <cf9fc950116aefcc4cf1ed310e42aef38d2f8de7.camel@mengyan1223.wang>
v2: change the comment along with the code
I must have been too sleepy in recent two days...
--
In "mips: align stack in clone [BZ #28223]"
(commit 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe) I made a mistake: I
misbelieved one "word" was 2-byte and "doubleword" should be 4-byte.
But in MIPS ABI one "word" is defined 32-bit (4-byte), so "doubleword" is
8-byte [1], and "quadword" is 16-byte [2].
[1]: "System V Application Binary Interface: MIPS(R) RISC Processor
Supplement, 3rd edition", page 3-31
[2]: "MIPSpro(TM) 64-Bit Porting and Transition Guide", page 23
---
sysdeps/unix/sysv/linux/mips/clone.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S
index 43a5ad3a40..fd71b5ca2e 100644
--- a/sysdeps/unix/sysv/linux/mips/clone.S
+++ b/sysdeps/unix/sysv/linux/mips/clone.S
@@ -55,11 +55,11 @@ NESTED(__clone,4*SZREG,sp)
.set at
#endif
- /* Align stack to 4/8 bytes per the ABI. */
+ /* Align stack to 8/16 bytes per the ABI. */
#if _MIPS_SIM == _ABIO32
- li t0,-4
-#else
li t0,-8
+#else
+ li t0,-16
#endif
and a1,a1,t0
--
2.32.0
On Fri, 2021-08-13 at 18:43 +0800, Xi Ruoyao wrote:
> Hi Joseph,
>
> Sorry for this, but I have to admit I've made an error in the previous
> patch. In MIPS documentations one "word" is defined 32-bit (4-byte), so
> a "doubleword" is 8-byte and a "quadword" is 16-byte. I misinterpreted
> "doubleword" as a "dword" we normally uses for 4-byte, so the alignment
> is actually insufficient.
next prev parent reply other threads:[~2021-08-13 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 16:58 [PATCH] mips: align stack in clone [BZ #28223] Xi Ruoyao
2021-08-12 17:20 ` Joseph Myers
2021-08-12 17:27 ` Xi Ruoyao
2021-08-12 20:32 ` Joseph Myers
2021-08-13 10:43 ` [PATCH] mips: increase stack alignment in clone to match the ABI Xi Ruoyao
2021-08-13 12:04 ` Xi Ruoyao [this message]
2021-08-13 16:02 ` [PATCH v2] " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7a3dc2e7a8ea4ba455614ecd8190adc05790c61.camel@mengyan1223.wang \
--to=xry111@mengyan1223.wang \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).