From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: Fix rpcgen buffer overrun (bug 20790)
Date: Tue, 08 Nov 2016 08:37:00 -0000 [thread overview]
Message-ID: <a7b77995-f53c-8cb5-54b3-a182f3cfa453@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1611071839320.3948@digraph.polyomino.org.uk>
On 11/07/2016 07:40 PM, Joseph Myers wrote:
> 2016-11-07 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #20790]
> * sunrpc/rpc_parse.c (get_prog_declaration): Increase buffer size
> to MAXLINESIZE.
> * sunrpc/bug20790.x: New file.
> * sunrpc/Makefile [$(run-built-tests) = yes] (rpcgen-tests): New
> variable.
> [$(run-built-tests) = yes] (tests-special): Add $(rpcgen-tests).
> [$(run-built-tests) = yes] ($(rpcgen-tests)): New rule.
This looks okay to me, all things considering. (Fixed-length buffers
are against GNU coding standards, but sunrpc/* doesn't really follow
them anyway.)
Thanks,
Florian
prev parent reply other threads:[~2016-11-08 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 18:40 Joseph Myers
2016-11-08 8:37 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b77995-f53c-8cb5-54b3-a182f3cfa453@redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).