From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id EBCA33848023 for ; Thu, 20 May 2021 10:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EBCA33848023 Received: by mail-qt1-x82c.google.com with SMTP id c10so12356617qtx.10 for ; Thu, 20 May 2021 03:43:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F2/il3nNZ8WhyEyMHMTDDYODL58BNV6TGy8/CxJeZ14=; b=uY8DOZKRBmWPQ3xMidRPp/1TqYZ0wCNwi7osfCYTTQoRVfZrlom/u0kSn7KKtxpKml 8rTcuBpfUfs7pcZHQu7aMdrbDnFR6U+TFFxfEabmgHVAmNP1QG/6+W3BXU3HQ1oIm3bd sJrqq+JYq04CIcV99eQ7042/S5626vs6TArFlhPHF/PJy8anHifG432fWvCEL/w5gGte k27ALNwkJg2lXqpvpLWcThtOKH0ucUjNkz3OdheBnFUJIvbny37m0Rcd1eccvyW4yb2N tWJKCXwyXyXTkCOdo56ZO3ztSoJKDCpzaT75Fg4OYfYFyt6DXQ8rs+3ATqwud6yM/tVH 5UCw== X-Gm-Message-State: AOAM530+y9DY4SbNlFLAgQ5+zaSUGYfEqqqcxWW9r02p27lGyLbBsVGi gKechdykzY0C4GQ93f6wMsxPRW65SwK6Gw== X-Google-Smtp-Source: ABdhPJxAkKbVo1UHgjgySIBeHbk/s8TmHUwJ8Jy63FaNcldhih3FDcVUhqqsWmQQfy0214jLAuTNAA== X-Received: by 2002:a05:622a:113:: with SMTP id u19mr4283279qtw.323.1621507397422; Thu, 20 May 2021 03:43:17 -0700 (PDT) Received: from [192.168.1.4] ([177.194.37.86]) by smtp.gmail.com with ESMTPSA id y9sm1667544qkm.19.2021.05.20.03.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 03:43:17 -0700 (PDT) Subject: Re: [PATCH v2 01/25] linux: mips: Split libpthread.abilist in n32 and n64 To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> <20210518205613.1487824-2-adhemerval.zanella@linaro.org> <874kexucxp.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Thu, 20 May 2021 07:43:15 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <874kexucxp.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 10:43:19 -0000 On 20/05/2021 03:38, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> The n32 will require the 64 bit time symbols for y2038 support. >> --- >> .../mips/mips64/{ => n32}/libpthread.abilist | 0 >> .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15 +++++++++++++++ >> 2 files changed, 15 insertions(+) >> rename sysdeps/unix/sysv/linux/mips/mips64/{ => n32}/libpthread.abilist (100%) >> create mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist >> >> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist >> similarity index 100% >> rename from sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist >> rename to sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist >> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist >> new file mode 100644 >> index 0000000000..a5f3d5ce2a >> --- /dev/null >> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist >> @@ -0,0 +1,15 @@ >> +GLIBC_2.0 __errno_location F >> +GLIBC_2.0 pthread_create F >> +GLIBC_2.11 __libpthread_version_placeholder F >> +GLIBC_2.12 __libpthread_version_placeholder F >> +GLIBC_2.18 __libpthread_version_placeholder F >> +GLIBC_2.2 pthread_create F >> +GLIBC_2.2.3 __libpthread_version_placeholder F >> +GLIBC_2.2.6 __libpthread_version_placeholder F >> +GLIBC_2.28 thrd_create F >> +GLIBC_2.3.2 __libpthread_version_placeholder F >> +GLIBC_2.3.3 __libpthread_version_placeholder F >> +GLIBC_2.3.4 __libpthread_version_placeholder F >> +GLIBC_2.30 __libpthread_version_placeholder F >> +GLIBC_2.31 __libpthread_version_placeholder F >> +GLIBC_2.4 __libpthread_version_placeholder F > > That looks wrong, there are no time-dependent symbols left in > libpthread, so the split isn't needed. > > Thanks, > Florian > Indeed this patch is not required anymore (the libpthread files are not updated for n32 when the 64-bit time symbols). I will remove it.