From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] posix: Add internal symbols for posix_spawn interface
Date: Mon, 17 Sep 2018 19:10:00 -0000 [thread overview]
Message-ID: <a81d07ad-cffa-d93d-94fb-21f23c7b37f3@linaro.org> (raw)
In-Reply-To: <5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com>
On 17/09/2018 05:12, Florian Weimer wrote:
> On 09/15/2018 05:16 PM, Adhemerval Zanella wrote:
>> +__typeof (posix_spawn) __posix_spawn;
>> +libc_hidden_proto (__posix_spawn)
>
> I think libc_hidden_proto without a GLIBC_PRIVATE export doesn't make much sense. Why can't you use attribute_hidden here, like for the other new function symbols?
>
> Thanks,
> Florian
I had to use libc_hidden_proto because versioned_symbol with a hidden
symbol produces only a local one:
$ cat foo.c
void __foo () __attribute__ ((visibility ("hidden")));
void __foo ()
{
}
__asm__ (".symver __foo, foo@@LIBFOO_1.0");
$ cat libfoo.map
LIBFOO_1.0 {
global:
foo;
};
$ gcc -Wall -fpic -shared foo.c -o libfoo.so -Wl,-version-script=libfoo.map
$ objdump -t libfoo.so | grep -w foo
0000000000000000 l df *ABS* 0000000000000000 foo.c
00000000000005da l F .text 0000000000000007 foo@@LIBFOO_1.0
next prev parent reply other threads:[~2018-09-17 19:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 15:18 Adhemerval Zanella
2018-09-15 15:16 ` [PATCH 2/3] posix: Use posix_spawn on popen Adhemerval Zanella
2018-09-16 5:13 ` David Newall
2018-09-17 14:50 ` Rich Felker
2018-09-17 17:32 ` Adhemerval Zanella
2018-09-18 1:31 ` David Newall
2018-09-18 3:12 ` Rich Felker
2018-09-18 18:01 ` Zack Weinberg
2018-09-19 5:18 ` Rich Felker
2018-09-19 15:53 ` Adhemerval Zanella
2018-10-17 17:20 ` Adhemerval Zanella
2018-10-19 22:08 ` Adhemerval Zanella
2018-09-15 15:18 ` [PATCH 3/3] posix: Use posix_spawn on system Adhemerval Zanella
2018-10-17 20:13 ` Adhemerval Zanella
2018-09-17 12:12 ` [PATCH 1/3] posix: Add internal symbols for posix_spawn interface Florian Weimer
2018-09-17 19:10 ` Adhemerval Zanella [this message]
2018-09-21 13:09 ` Florian Weimer
2018-10-17 17:11 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81d07ad-cffa-d93d-94fb-21f23c7b37f3@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).