From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29076 invoked by alias); 17 Sep 2018 19:10:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 28974 invoked by uid 89); 17 Sep 2018 19:10:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Gm-Message-State:APzg51C, H*r:sk:38-v6so X-HELO: mail-pl1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UiM7H0YbH3G0vsWXMFJihaqgf3P7IHlGHGJDv48eGFg=; b=DFp1bQfnsCGC91mHBYT1JTFMq9pkbPrnCzKe420678NZZpJ2xUfRcFT960/EHzV0KA p8uPRABbwZBlk0EWtVKWIg9210odIOU7ATZKKg4JOyKXHE5vAowk45WnQmGeG/KH5kEq KBSWiObqmwGMDWJadxwWL04e1Ziji7+Ihw6KQ= Return-Path: Subject: Re: [PATCH 1/3] posix: Add internal symbols for posix_spawn interface To: Florian Weimer , libc-alpha@sourceware.org References: <20180915151622.17789-1-adhemerval.zanella@linaro.org> <5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: Date: Mon, 17 Sep 2018 19:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg00256.txt.bz2 On 17/09/2018 05:12, Florian Weimer wrote: > On 09/15/2018 05:16 PM, Adhemerval Zanella wrote: >> +__typeof (posix_spawn) __posix_spawn; >> +libc_hidden_proto (__posix_spawn) > > I think libc_hidden_proto without a GLIBC_PRIVATE export doesn't make much sense.  Why can't you use attribute_hidden here, like for the other new function symbols? > > Thanks, > Florian I had to use libc_hidden_proto because versioned_symbol with a hidden symbol produces only a local one: $ cat foo.c void __foo () __attribute__ ((visibility ("hidden"))); void __foo () { } __asm__ (".symver __foo, foo@@LIBFOO_1.0"); $ cat libfoo.map LIBFOO_1.0 { global: foo; }; $ gcc -Wall -fpic -shared foo.c -o libfoo.so -Wl,-version-script=libfoo.map $ objdump -t libfoo.so | grep -w foo 0000000000000000 l df *ABS* 0000000000000000 foo.c 00000000000005da l F .text 0000000000000007 foo@@LIBFOO_1.0