From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from slateblue.cherry.relay.mailchannels.net (slateblue.cherry.relay.mailchannels.net [23.83.223.168]) by sourceware.org (Postfix) with ESMTPS id C0EB73858D33 for ; Tue, 3 Oct 2023 17:25:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0EB73858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DF41B760C25; Tue, 3 Oct 2023 17:25:17 +0000 (UTC) Received: from pdx1-sub0-mail-a208.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A7B99762CA7; Tue, 3 Oct 2023 17:25:16 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696353916; a=rsa-sha256; cv=none; b=UURZzVCRPXP3noJxxIfdeZd91z+6mykzH3dgwuSfrjstuXRxvgtCoQlPjgX855rwzkTDwZ O6B+MqYHu79XI1E94ECR/E5qBAYEdENXLIek4yhXEPlUfN+hx1qAXRIKuPGKdhpGaWBPcq AzjAodmx2VCUTcFnnb2DGu3o03rnPNrsArYsE0rtng/u5ytlQSnRSgmrvMPdv9Q7+mGYrW vX2d055/d2/G17Zc68NnpJYsaalIQaLQxtoIQFzzAlLDZxDNoxUechjTo6loA1yu9Gundd JIkEneFmzXg5brdp7Zo4w6F0ww7h6bR3fkLwJYaonzz/5EF41ZTQnQI+ib4WLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696353916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5hs8r13X3qZ0SliAcxIXALvDfK7yMpiIzJ4vTEkXv04=; b=9C15nfKKbhhlapgabgCQYH0TFcvB1A1wQrurfERmCCEN72dRXDxjOJY3JH+EOGE5EGNCQj JIeN5AqUFBkR7aOMELVuMIjNSh/z60FN1lrtW8DFEsS+ZYJDg4Ccf5ruvG9sXdu8TVt2da A5STSB4SqOEYZuD9O3SADvGrdT/7phoPLUgQaavr0ikJZImlreephgdBl/5vSS2bXKljau TvQbLMpWP5LxcgpSuFBZqHbYt/c2TnWo73QjW+gmaFVa1GC3dZJpl0Sx4pqNeDJWptnqnz Xr/NEcDItKZjlnXRqIx4tT1u2BU+KflqKClUFNSu6IcAuNc07/GOUcjAhKwPJw== ARC-Authentication-Results: i=1; rspamd-7c449d4847-s7p8h; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Quick-Print: 633e4a803ad0232d_1696353917723_4171886021 X-MC-Loop-Signature: 1696353917723:3861498597 X-MC-Ingress-Time: 1696353917723 Received: from pdx1-sub0-mail-a208.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.159.71 (trex/6.9.1); Tue, 03 Oct 2023 17:25:17 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a208.dreamhost.com (Postfix) with ESMTPSA id 4S0Pph1npTzPd; Tue, 3 Oct 2023 10:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1696353916; bh=5hs8r13X3qZ0SliAcxIXALvDfK7yMpiIzJ4vTEkXv04=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=EoTQTMmuy+31fmzbC6ZNc3mj8EQYEw60tr4bZ+J+9r0rg4lT/nuOmWI55Zt6yHGf8 fvQvjfO5rN9YY6YH+FDkcd0j0TzULR/99a//q+OiMykR5z98XZpKkuXyOxETLexk1d UH2E/E8bcvUjWH3w8ZwnDPvW8hgL7/kdPgirK3HZQSzJC5bA/LIl/VtKtxQuKvVDGh 0mA0tzPxrJfR6vY93lVsQ4McoxSS+6fcFvKkw1s4Ov0NXWqI+M+8fHk8xZ6oep/6Ei QqPlY8KXUzgCcXPX749+ZP/9BtLJvPJyUouZeH1PbRurgHeQ/IqSX/EWjrEcIhuiT6 YsOfofzryncrw== Message-ID: Date: Tue, 3 Oct 2023 13:25:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] Fix FORTIFY_SOURCE false positive Content-Language: en-US To: =?UTF-8?Q?Volker_Wei=c3=9fmann?= , libc-alpha@sourceware.org References: <20231003171844.9586-1-volker.weissmann@gmx.de> Cc: Adhemerval Zanella From: Siddhesh Poyarekar In-Reply-To: <20231003171844.9586-1-volker.weissmann@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-03 13:18, Volker Weißmann wrote: > When -D_FORTIFY_SOURCE=2 was given during compilation, > sprintf and similar functions will check if their > first argument is in read-only memory and exit with > *** %n in writable segment detected *** > otherwise. To check if the memory is read-only, glibc > reads frpm the file "/proc/self/maps". If opening this > file fails due to too many open files (EMFILE), glibc > will now ignore this error. > > Fixes [BZ #30932] > > Signed-off-by: Volker Weißmann > --- Thanks! LGTM. Reviewed-by: Siddhesh Poyarekar Adhemerval, could you please add this with your test case patch and send it as a series? I can then review that too. Thanks, Sid > sysdeps/unix/sysv/linux/readonly-area.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/readonly-area.c b/sysdeps/unix/sysv/linux/readonly-area.c > index edc68873f6..ba32372ebb 100644 > --- a/sysdeps/unix/sysv/linux/readonly-area.c > +++ b/sysdeps/unix/sysv/linux/readonly-area.c > @@ -42,7 +42,9 @@ __readonly_area (const char *ptr, size_t size) > to the /proc filesystem if it is set[ug]id. There has > been no willingness to change this in the kernel so > far. */ > - || errno == EACCES) > + || errno == EACCES > + /* Process has reached the maximum number of open files. */ > + || errno == EMFILE) > return 1; > return -1; > } > -- > 2.42.0 >