* [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
@ 2018-05-15 17:13 leonardo.sandoval.gonzalez
2018-05-15 18:32 ` Florian Weimer
0 siblings, 1 reply; 5+ messages in thread
From: leonardo.sandoval.gonzalez @ 2018-05-15 17:13 UTC (permalink / raw)
To: libc-alpha; +Cc: hjl.tools, Leonardo Sandoval
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Tested on 64-bit AVX machine
* sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S (MEMMOVE):
remove duplicate line on PREFETCH_ONE_SET macro
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
index cbd0d077cf6..1404131bb71 100644
--- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
+++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
@@ -90,7 +90,6 @@
# define PREFETCH_ONE_SET(dir, base, offset) \
PREFETCH ((offset)base); \
PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
- PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
PREFETCH ((offset + dir * PREFETCH_SIZE * 2)base); \
PREFETCH ((offset + dir * PREFETCH_SIZE * 3)base)
# else
--
2.17.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
2018-05-15 17:13 [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro leonardo.sandoval.gonzalez
@ 2018-05-15 18:32 ` Florian Weimer
2018-05-15 18:47 ` Leonardo Sandoval
2018-05-16 17:03 ` Leonardo Sandoval
0 siblings, 2 replies; 5+ messages in thread
From: Florian Weimer @ 2018-05-15 18:32 UTC (permalink / raw)
To: leonardo.sandoval.gonzalez; +Cc: libc-alpha, hjl.tools
* leonardo sandoval gonzalez:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Tested on 64-bit AVX machine
>
> * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S (MEMMOVE):
> remove duplicate line on PREFETCH_ONE_SET macro
This should be:
* sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
(PREFETCH_ONE_SET): Remove duplicate line.
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
We don't use DCO, so this line is very misleading and should not be
present.
Looks good otherwise. Do you have commit access?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
2018-05-15 18:32 ` Florian Weimer
@ 2018-05-15 18:47 ` Leonardo Sandoval
2018-05-16 17:03 ` Leonardo Sandoval
1 sibling, 0 replies; 5+ messages in thread
From: Leonardo Sandoval @ 2018-05-15 18:47 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, hjl.tools
On Tue, 2018-05-15 at 20:27 +0200, Florian Weimer wrote:
> * leonardo sandoval gonzalez:
>
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com
> > >
> >
> > Tested on 64-bit AVX machine
> >
> > * sysdeps/x86_64/multiarch/memmove-vec-unaligned-
> > erms.S (MEMMOVE):
> > remove duplicate line on PREFETCH_ONE_SET macro
>
> This should be:
>
> * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> (PREFETCH_ONE_SET): Remove duplicate line.
>
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.
> > intel.com>
>
> We don't use DCO, so this line is very misleading and should not be
> present.
>
I will send a v2.
> Looks good otherwise. Do you have commit access?
No
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
2018-05-15 18:32 ` Florian Weimer
2018-05-15 18:47 ` Leonardo Sandoval
@ 2018-05-16 17:03 ` Leonardo Sandoval
2018-05-16 17:04 ` Florian Weimer
1 sibling, 1 reply; 5+ messages in thread
From: Leonardo Sandoval @ 2018-05-16 17:03 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, hjl.tools
On Tue, 2018-05-15 at 20:27 +0200, Florian Weimer wrote:
> * leonardo sandoval gonzalez:
>
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com
> > >
> >
> > Tested on 64-bit AVX machine
> >
> > * sysdeps/x86_64/multiarch/memmove-vec-unaligned-
> > erms.S (MEMMOVE):
> > remove duplicate line on PREFETCH_ONE_SET macro
>
> This should be:
>
> * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> (PREFETCH_ONE_SET): Remove duplicate line.
>
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.
> > intel.com>
>
> We don't use DCO, so this line is very misleading and should not be
> present.
>
> Looks good otherwise. Do you have commit access?
Florian, can someone check (perhaps you) if I now have commit access?
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-16 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 17:13 [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro leonardo.sandoval.gonzalez
2018-05-15 18:32 ` Florian Weimer
2018-05-15 18:47 ` Leonardo Sandoval
2018-05-16 17:03 ` Leonardo Sandoval
2018-05-16 17:04 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).