From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 354863851C24 for ; Mon, 5 Apr 2021 11:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 354863851C24 Received: by mail-ed1-x534.google.com with SMTP id h10so12121691edt.13 for ; Mon, 05 Apr 2021 04:13:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EisEkN+nCXku7J5+S3sZOKkPVt0M19SYdm2CK/WJNCE=; b=Q4pA4lHY0XriUEECLXcVx28tpD/A1prtLjtdkTxjcoYvxF8AlhuYdzFlB4a7Kx0JwX bGGB2KdKSPCForD/pTUxtK0zBN9vm7WQ7fcHLB4yzhU7gMMkihza3Mt79y4RNTlWU+CG E1UFl7JWOc6a/tYJ+QgVJ4MmDmotahmoNBd0EK6XJO7fbExgWzq/9HCbbzsnmZw8Seja ZUuxaNPr+PdI16rBxMQ5m4JGbQ1UlQ6YrY3tXsKiPaoCIoV+VAG6nb45fafitPVlQU9l bqMi4y2OgBnskbR8SOdYOKLncZ8anQW6lg8ky2Ng9oOsYSmtNLuPuCoE7hl3gS3TqzaP 3spw== X-Gm-Message-State: AOAM531+V+fCgLBpPqTufBFssed8SzKHe1OJvwZubumN5Z+ZPwsukQVr vp99RdQ7BvdXg4qjqDccbDBWTrBMxpg= X-Google-Smtp-Source: ABdhPJy6V2xV/R7QjrLUYtBBitq5a96Pt8UUZXCsGr1JWjujnloE1tQdicx/JLHNizQjjYYLk2/PXw== X-Received: by 2002:a05:6402:2363:: with SMTP id a3mr6732550eda.130.1617621218099; Mon, 05 Apr 2021 04:13:38 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id y21sm2703851edv.31.2021.04.05.04.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:13:37 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v5 31/35] ioctl_ficlonerange.2: Make clear why is each header exactly needed. To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-32-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Mon, 5 Apr 2021 13:13:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-32-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 11:13:40 -0000 Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > Only the one that provides the prototype doesn't need a comment. > > Signed-off-by: Alejandro Colomar Patch applied. Thanks, Michael > --- > man2/ioctl_ficlonerange.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/ioctl_ficlonerange.2 b/man2/ioctl_ficlonerange.2 > index 34c171941..75ab14bc4 100644 > --- a/man2/ioctl_ficlonerange.2 > +++ b/man2/ioctl_ficlonerange.2 > @@ -25,8 +25,8 @@ > ioctl_ficlonerange, ioctl_ficlone \- share some the data of one file with another file > .SH SYNOPSIS > .nf > +.BR "#include " " /* Definition of " FICLONE* " constants */" > .B #include > -.B #include > .PP > .BI "int ioctl(int " dest_fd ", FICLONERANGE, struct file_clone_range *" arg ); > .BI "int ioctl(int " dest_fd ", FICLONE, int " src_fd ); > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/