From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1185C3858D35 for ; Tue, 1 Feb 2022 20:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1185C3858D35 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-o8zoXYb4Mom6H2ERe1kazQ-1; Tue, 01 Feb 2022 15:02:14 -0500 X-MC-Unique: o8zoXYb4Mom6H2ERe1kazQ-1 Received: by mail-qv1-f70.google.com with SMTP id iv13-20020ad45ced000000b004248c87cc4cso16896601qvb.10 for ; Tue, 01 Feb 2022 12:02:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=qaktXDtg6PQeIBGHXzcz/hR4QkSHMGdzp+F9kSjlIZU=; b=EV58Qoo4ndkA0P5FxVtaPjI2L7viiZl5a/Rek5MPQZhLRt9XffRfr/yWiwiHib/n5K wusCn8pWJO86eInsS9Kmsz36x7YTBbpny828w5M/E6tmelDjRVpawE3DF1W74yRNxvLZ eWBqarFub3OrnF6Awij+ttlUWb/FQhXImQeALYCGL8rtKX3UClIEgEW17lNr+ljP8ELj p+aL/rNPSv6nB/4upsgS3h3M/5OlPcdrWHpjAysz7IygC/vOiOvIqqJgITYaMU1clX22 gvUoVntYikGxWJJZvTmqPpb4SGHptsXiU4NmwThme6ST+hxevjavcKWKByKX6KuIOzXn dY3w== X-Gm-Message-State: AOAM531ZVoyUetGAmfHBvNOOejWc8H6vW5Dzm3gGjJR+SE16MLVXHpDy JKag81RZBD4ipBS/EwLP33MWWHQAqiPaXOX8pMXaj6bR4V7Bd1hTfcv9LRYOMDNNUEkejB15Awc ezfjiQcZh55ubPRnIO3Me X-Received: by 2002:a05:620a:782:: with SMTP id 2mr17590487qka.523.1643745734097; Tue, 01 Feb 2022 12:02:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzwA9hHUV8t7fOsMfXSkBOSRZuHlQzrwxOoeyyayl+4fKrLeXEqKjricGbc6x8fLgQxewlTWw== X-Received: by 2002:a05:620a:782:: with SMTP id 2mr17590464qka.523.1643745733861; Tue, 01 Feb 2022 12:02:13 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id u11sm3865160qkp.96.2022.02.01.12.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 12:02:13 -0800 (PST) Message-ID: Date: Tue, 1 Feb 2022 15:02:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] posix: Replace posix_spawnattr_tc{get, set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np To: Florian Weimer , Adhemerval Zanella Cc: libc-alpha@sourceware.org, "H . J . Lu" References: <20220129200620.501423-1-adhemerval.zanella@linaro.org> <87zgna1mkp.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87zgna1mkp.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 20:02:23 -0000 On 2/1/22 13:14, Florian Weimer wrote: > * Adhemerval Zanella: > >> @@ -235,6 +220,13 @@ posix_spawn_file_actions_addclosefrom_np (posix_spawn_file_actions_t *, >> int __from) >> __THROW __nonnull ((1)); >> >> +/* Add an action fo set the terminal foregroup process group on the terminal > > Typo: foregrou[nd] > > The API addition looks okay to me. > > I've also checked that this patch passes build-many-glibcs.py. I pulled the patch into Fedora Rawhide and reviews on x86_64, i686, s390x, ppc64le, aarch64 and armv7hl. No issues there. My local x86_64 and i686 builders (non-rawhide with special configs with linux kernel head headers) are also clean. Let me go through a quick review and then we'll adjust the API for release. -- Cheers, Carlos.