From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id AA2763858D1E for ; Tue, 7 Nov 2023 12:48:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA2763858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA2763858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699361320; cv=none; b=oby2i7TGV6+k4hymE71qy5qcUipXQPWDuhZSc3lprBi5AJU7O0yLxWzxV2tqtVmVlTN183w2hrHieJn9YqyoS9o+IXRXC84/JrXqu7NlqJUvqEu7OmwQDC0y3DQHRkM2k0kemzMRevW4LT8NEvyDYv0vwmCtAbZpktIieKy1tr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699361320; c=relaxed/simple; bh=BrZreDsIGx9B7RAoRAfReDoz/Vfr/SrGfKm5ldCIZew=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ROoS9hFJrfsXziq64iF7m4COMFgZizcuYQaAJMieLCOQyWMkT8Mbp3EdveVHy8EUmEQpkP+SXsxOUtggEFUXDDjh26AUDQI6qcXrIUaWwZRZ1QmU2eynMKAu0Mqy8kcgPcH7hB/jNd7Vni+rySv5eb24eE/uA96lzKNf9LLUNQo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-d9fe0a598d8so5473349276.2 for ; Tue, 07 Nov 2023 04:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699361318; x=1699966118; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=lCojon235UPRHkwfsfy4BI4cM55viU+8Z1a3rPq7m+w=; b=FjyMDUHuHzql890xV2dyDFPoU8azQymtM/8IZXkncyf6li1PVIlKix7oyr49AItExZ PR1MeQGIoXiqy8XO56WgNjF0wedpTGKP/DSANbcn5SxZ1lgR10NZKPZpTcm6UJq+e9Km 0b5SG0vaCDvHB/AGruHoKuopO0bun9huJFAMa9c34m5aQ/kdJ4dTbC8rFxEYX2f8VA+5 w8M1b4ldozBr/DRDz8icVEVjjLX4NPRTJVodNpzuKi4j05c+lO9RDt81xGA1DQHo6bpn woJsr55+jF6yWhX1MB9/dQhdhtYMgU9YWJk7Yh+IPBpYqXCxxASkOW+CFWIYRHnby7Wu X/uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699361318; x=1699966118; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lCojon235UPRHkwfsfy4BI4cM55viU+8Z1a3rPq7m+w=; b=bcTxZvVGsHzoDCWqCdS0kV6YAOZkcEJF0CLV9bk1x3SZPHnuN+eFoavyfTn0vQpWSZ 4ME+1syjX7nBfgTcJQppgkseD/pAqfHXdGcstAWLc6aSoI4LyQqlQOXZD5lRUa+HKW0B UZufl4ayyNd7IkSZjehc03As6ASa+a3UzDRuwaomjb0y8WLpNhvq/xVFVxrScLkywkds eHNKGGslSqJsot4zXcdbtJWDtbob03qio61J00nabsLcIw9Aay8Eb6L8dhDPGl5k9LBW SocB5vYgjvEa9VTG2Va+emX065mzjQ/RdhwGBOgfW66SbN4Zmjsx/sYrDHiDjU8OpDEx m5Vg== X-Gm-Message-State: AOJu0YzSzQ7zEIQ0A6F5gn71Sj2Yr32AWMI77uJc52pxy1vfrblLLm/V MbU8LxK9YZjdODXlCpP7KNMYDQ== X-Google-Smtp-Source: AGHT+IGvZZYgUtVPrxsyyacMY/lYxzshWc8O5l+PTWVsqQ+ZbByuKhbANgb5IGw+gM3BF8HUpKsVMQ== X-Received: by 2002:a25:d152:0:b0:da0:3bfc:b915 with SMTP id i79-20020a25d152000000b00da03bfcb915mr29667891ybg.11.1699361317976; Tue, 07 Nov 2023 04:48:37 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:a715:b54d:6aa1:153d:b806? ([2804:1b3:a7c0:a715:b54d:6aa1:153d:b806]) by smtp.gmail.com with ESMTPSA id l10-20020a056902000a00b00d9a3fe483cfsm4864349ybh.23.2023.11.07.04.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 04:48:37 -0800 (PST) Message-ID: Date: Tue, 7 Nov 2023 09:48:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: rustc SIGILL since qsort_r patches Content-Language: en-US To: Florian Weimer Cc: Andrew Pinski , =?UTF-8?Q?Cristian_Rodr=C3=ADguez?= , Adhemerval Zanella via Libc-alpha References: <874jhxizve.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <874jhxizve.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/11/23 08:09, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> Just a side note that the quicksort implementation was also used for >> size (number of elements times size per element) larger than the >> installed system RAM (_SC_PHYS_PAGES / size > _SC_PAGESIZE) or >> whether malloc fails. So it is a latent issue, that did not trigger >> before by chance. > > Is it ever beneficial to call the comparison function with identical > pointers, though? Afaik this how introsort works, and I am not aware of any comparison sort with O(1) worst-case space complexity that does not require a comparison callback that work as <=>. > > This change is going to have annoying consequences for backwards > compatibility. > > Thanks, > Florian >