[PATCH v2] Support auxilliary vector components for cache geometries.

[PATCH v2] Support auxilliary vector components for cache geometries.

[Paul Clarke]

Add support to getauxval() for new types to get L1, L2, L3 cache sizes,
cache line sizes, and cache associativities.  The new types for
getauxval() were added in the stream for Linux kernel v4.11 in commit
98a5f361b8625c6f4841d6ba013bbf0e80d08147.

	* elf/elf.h: Add auxvec identifiers from kernel
	arch/powerpc/include/uapi/asm/auxvec.h.
---
v2: removed test case

  elf/elf.h | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/elf/elf.h b/elf/elf.h
index 6d3b356..fff893d 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -1170,6 +1170,18 @@ typedef struct
  #define AT_L2_CACHESHAPE	36
  #define AT_L3_CACHESHAPE	37
  
+/* Shapes of the caches, with more room to describe them.
+   *GEOMETRY are comprised of cache line size in bytes in the bottom 16 bits
+   and the cache associativity in the next 16 bits.  */
+#define AT_L1I_CACHESIZE	40
+#define AT_L1I_CACHEGEOMETRY	41
+#define AT_L1D_CACHESIZE	42
+#define AT_L1D_CACHEGEOMETRY	43
+#define AT_L2_CACHESIZE		44
+#define AT_L2_CACHEGEOMETRY	45
+#define AT_L3_CACHESIZE		46
+#define AT_L3_CACHEGEOMETRY	47
+
  /* Note section contents.  Each entry in the note section begins with
     a header of a fixed form.  */
  
-- 
2.1.4

Regards,
Paul Clarke, IBM

Re: [PATCH v2] Support auxilliary vector components for cache geometries.

[Carlos Eduardo Seo]

On 3/23/17, 2:25 PM, "Paul Clarke" <libc-alpha-owner@sourceware.org on behalf of pc@us.ibm.com> wrote:

    Add support to getauxval() for new types to get L1, L2, L3 cache sizes,
    cache line sizes, and cache associativities.  The new types for
    getauxval() were added in the stream for Linux kernel v4.11 in commit
    98a5f361b8625c6f4841d6ba013bbf0e80d08147.
    

LGTM


--
Carlos Eduardo Seo
Software Engineer - Linux on Power Toolchain
cseo@linux.vnet.ibm.com
 

Re: [PATCH v2] Support auxilliary vector components for cache geometries.

[Paul Clarke]

ping.

On 03/23/2017 12:25 PM, Paul Clarke wrote:
> Add support to getauxval() for new types to get L1, L2, L3 cache sizes,
> cache line sizes, and cache associativities.  The new types for
> getauxval() were added in the stream for Linux kernel v4.11 in commit
> 98a5f361b8625c6f4841d6ba013bbf0e80d08147.
>
> 	* elf/elf.h: Add auxvec identifiers from kernel
> 	arch/powerpc/include/uapi/asm/auxvec.h.
> ---
> v2: removed test case
>
>   elf/elf.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 6d3b356..fff893d 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1170,6 +1170,18 @@ typedef struct
>   #define AT_L2_CACHESHAPE	36
>   #define AT_L3_CACHESHAPE	37
>
> +/* Shapes of the caches, with more room to describe them.
> +   *GEOMETRY are comprised of cache line size in bytes in the bottom 16 bits
> +   and the cache associativity in the next 16 bits.  */
> +#define AT_L1I_CACHESIZE	40
> +#define AT_L1I_CACHEGEOMETRY	41
> +#define AT_L1D_CACHESIZE	42
> +#define AT_L1D_CACHEGEOMETRY	43
> +#define AT_L2_CACHESIZE		44
> +#define AT_L2_CACHEGEOMETRY	45
> +#define AT_L3_CACHESIZE		46
> +#define AT_L3_CACHEGEOMETRY	47
> +
>   /* Note section contents.  Each entry in the note section begins with
>      a header of a fixed form.  */
>
>

Re: [PATCH v2] Support auxilliary vector components for cache geometries.

[Florian Weimer]

* Paul Clarke:

> ping.

Carlos already acked this patch.  Do you need someone to commit it?
Do you plan to submit more glibc work in the future?

(But see my earlier comments about your initial test.)

Re: [PATCH v2] Support auxilliary vector components for cache geometries.

[Paul Clarke]

On 03/30/2017 03:15 PM, Florian Weimer wrote:
> * Paul Clarke:
>
>> ping.
>
> Carlos already acked this patch.  Do you need someone to commit it?

I can ask Tulio to commit.  Sorry, but I wasn't quite sure what qualifies as "approved for commit".

> Do you plan to submit more glibc work in the future?

Yes.

PC

Re: [PATCH v2] Support auxilliary vector components for cache geometries.

[Tulio Magno Quites Machado Filho]

Paul Clarke <pc@us.ibm.com> writes:

> On 03/30/2017 03:15 PM, Florian Weimer wrote:
>> * Paul Clarke:
>>
>>> ping.
>>
>> Carlos already acked this patch.  Do you need someone to commit it?
>
> I can ask Tulio to commit.  Sorry, but I wasn't quite sure what qualifies as "approved for commit".

I made few changes to ChangeLog entry and pushed it as d031600d.

Thanks!

-- 
Tulio Magno