From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id 28A803857C61 for ; Tue, 30 Mar 2021 12:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 28A803857C61 Received: by mail-qv1-xf2d.google.com with SMTP id 30so7957943qva.9 for ; Tue, 30 Mar 2021 05:12:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pB/hgOc3cb5MJ9Cod/sVm1AxSd6l9cTRKCqObkEaNqw=; b=IeYHa1d7P+aJ2qHF0aj50k+rgRSqrRVVbHSZi+Qjqfn/Vr7TcSsZ7QXXSNpDOVrhz1 XGQLTyysy4Zab+LHudWTcMOOxwoimQVMl6HqbCp7K4gaceaW5kPjdkmXDMmAVXg0rafK LQeZmonIErOX+NL7rOLQKdwBcaNWp3MuuEeqQx19v/Y0pTDbVM1k98/TlFX0BdaWKq35 6vfx1YG2L5ViU1y14WfHw3tB+z2ZfIv7aGFBBbHzOi4sP0mhqs5/7Pt+pGlGhaXQwEIt fHMqU/GqnjxGyRduGwk8Im7K4p11TlgLYCQVnE2NdkcTlZMBEV+3vNLCZfhVOV+PEl/F GT4A== X-Gm-Message-State: AOAM532X9If0dE5/Sua1McQSXkXb9xvKVn5dP91uDPyoVvoJ0JPCwHIN ViZcHV6gKr7ey3L2NG3YSKHiQ5TKw94QRZwZ X-Google-Smtp-Source: ABdhPJxvXIyhPj38fGbaFtI/4wauCjELsxhsnJZYNbY6uAEVQ27eMcBiky3dalbcsZr8fXy61XxQow== X-Received: by 2002:a0c:aa04:: with SMTP id d4mr29595377qvb.16.1617106343542; Tue, 30 Mar 2021 05:12:23 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id a138sm15447382qkg.29.2021.03.30.05.12.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Mar 2021 05:12:23 -0700 (PDT) Subject: Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment To: "Alejandro Colomar (man-pages)" , libc-alpha@sourceware.org References: <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> <20210324182915.29042-1-alx.manpages@gmail.com> <97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org> From: Adhemerval Zanella Message-ID: Date: Tue, 30 Mar 2021 09:12:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2021 12:12:27 -0000 On 29/03/2021 18:53, Alejandro Colomar (man-pages) wrote: > > > On 3/29/21 11:04 PM, Adhemerval Zanella wrote: >> >> >> On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >>> 'this' can be understood as the current parameter, but in this case it >>> is meaning the other one, the one holding the width/precission. >>> >>> 'it' better describes that parameter, differentiating it from the >>> one corresponding to the current specifier. >>> >>> Signed-off-by: Alejandro Colomar >> >> We don't use SCO, but rather Copyright assignment. The rest looks good >> to me (although I am not a native speaker). > > I hope you don't need a copyright assignment for such a small change :). > I guess a simple statement in this email that you can do as you wish > with this patch should be enough. I don't think it would require for such changes, it is more a warning that we do use 'Signed-off-by:' in the patch submission. > > Anyway, I hereby assign copyright of this patch to the glibc copyright > holder(s). This change is simple and fits in the trivial one, I will push it for you. > > Cheers, > > Alex > > > >> >> Reviewed-by: Adhemerval Zanella >> >>> --- >>> stdio-common/printf-prs.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >>> index 1d4e00553d..8ebf09a0a9 100644 >>> --- a/stdio-common/printf-prs.c >>> +++ b/stdio-common/printf-prs.c >>> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >>> /* Parse this spec. */ >>> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >>> >>> - /* If the width is determined by an argument this is an int. */ >>> + /* If the width is determined by an argument, it is an int. */ >>> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >>> argtypes[spec.width_arg] = PA_INT; >>> >>> - /* If the precision is determined by an argument this is an int. */ >>> + /* If the precision is determined by an argument, it is an int. */ >>> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >>> argtypes[spec.prec_arg] = PA_INT; >>> >>> >