From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 0758A3858D35 for ; Tue, 6 Feb 2024 13:00:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0758A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0758A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707224419; cv=none; b=nV+hl7NllEbnc5ZM2KoqKyi+lLi2skC9+mdfByrXKMXFBMARFHicw8HG12NyTV+xT73aHUnDPX52jg46OvGj5DgkIfCb4aHXDl8q9IiHvIjTUEoawC7Rrzj3iwHQoi75oRZAdl+qSYHAsOoMROocbI7Rl06eCbYKNP8zc81VOQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707224419; c=relaxed/simple; bh=QoZtyk0u1oLALcQchTvByWZj0NKOSsN3AKYDXUqyu1o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CJVJs2j8+ZHWe5B76Oen3R4SQZvShAcEZYa8Xek13kZ2GZTzKwMNQOjzw2bchiINHBJ1z5P9azgCPELGWpXZWhPHPtV+eOgw2vnPhyllIUlmE8ppaoOe1PPff7+amFHEP2wxhs85x10jFGjoP/mwj28vJ+53KkDWVClwLbpWXKk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d93edfa76dso47354575ad.1 for ; Tue, 06 Feb 2024 05:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707224416; x=1707829216; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+Y1sPX/2D+IOpEn/atTWon3UYuF/e/MFLC5qjUunPj0=; b=FD8KEkhrbPP6UQZpdtqeeWHY7ag4dmvsUp+LB0OQRxlUWNTqhrqP1PTopnxsg1AoV5 /elpF5lIDfPwwIefBu6AImlV+zk56epWEM8j9vwbP0brzFQDy84blPNxQnODWDVgB5pa oa/Y4zNDWZYqUF9m3v4gyPbrLmuENTjrN4nT0Z/DtDGlHOd7YVu2WIp9t6+hZelTlf4d /QxFgIeV8L6vHTfA5GPYCGhYX3mMErYTaupi++Ys8taCpaOpWtK6a+JxhI4Za4EYYy3K gNmceV3qpxnvoSEpfw1dg3YVzuJaGCvUA+8qnfeZOraraT1+eZPlq9jyeP4O8VFv2bZK U2VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707224416; x=1707829216; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Y1sPX/2D+IOpEn/atTWon3UYuF/e/MFLC5qjUunPj0=; b=mkGphpSM1KwZhY3Nu5VDtFuYFtaXiwNpdgSwikrGZrnrhSq0p8siG1TC0vRgO5ZbkQ B8ywcHgzqsaan7RuV49ByNgm5hMTkLKRrK8KfKJMr9ERnr29/1ZTbedxLw18wrN53Bim KjTEcjLI9cbrkclq5SKOLFjJ/tUVCT20qmqXmbn2Vc6OoSmO56E50C0oL1KC/YadoFM1 7okO1FbbdtyRecBUlG+pRS2XRTA1UypB2cvXLBp42cHTT4eNPGX177bJhKSMQCRPleOg MHjymjHf7/pkSf/XJT5JbTFtO8Upb/sLWF0GMhfBEPlXBkTxCllLMTB9pPpksmq8Kk+X pmqA== X-Gm-Message-State: AOJu0YxdaBQTjoSfmVSK9ewAINie9V2XVZHYLEgPF5eXEalEHDateQih KwJLWttm42BZNJZqQZi8p2M0mBur0iTK5b65Hnyo8b+JMy+P1lD7FWRe9xnJ/j9uPvS3NBX7v0R tjyE= X-Google-Smtp-Source: AGHT+IGIZK46Rzf0HSs0mr1DQ/nQuthTOj3Ti/vEy+yrKiWaCuM8BMDqwgOlT7TcvH6XyRwKIW6kDg== X-Received: by 2002:a17:903:32cb:b0:1d9:bdbc:388a with SMTP id i11-20020a17090332cb00b001d9bdbc388amr1674530plr.20.1707224415954; Tue, 06 Feb 2024 05:00:15 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXCOWWqaZd74vXwG1wau24s59RXNu5coWaOUyi43TQJMnOVRb9B/jeH+vyckxD0/LRqTKM6p1K8ONMJvJlVi3zH9njod3JEUdx9TRIDlcKduowsPwo6B87QleEbYmBVFWyDyd8AsK/9i659HVg/1T3F9cxBdbeXYdwXELrDRKpCRzaGBLQH/Y8zRsLmq+zEbh9xYQpROJS5uujL+GlxrUFapd17oT1ijL2cnx8LPavlk4VaeeHPfN0= Received: from [192.168.15.31] ([191.205.82.37]) by smtp.gmail.com with ESMTPSA id z6-20020a170903018600b001d95d47cce4sm1789304plg.138.2024.02.06.05.00.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 05:00:14 -0800 (PST) Message-ID: Date: Tue, 6 Feb 2024 10:00:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] x86: Improve ERMS usage on Zen3+ Content-Language: en-US To: Sajan Karumanchi Cc: bmerry@sarao.ac.za, goldstein.w.n@gmail.com, hjl.tools@gmail.com, libc-alpha@sourceware.org, pmallapp@amd.com, sajan.karumanchi@amd.com, fweimer@redhat.com References: <20240205190108.2332109-1-sajan.karumanchi@amd.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240205190108.2332109-1-sajan.karumanchi@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/02/24 16:01, Sajan Karumanchi wrote: > > Adhemerval, > > In our extensive testing, we observed mixed results for rep-movs/stos performance with the ERMS feature enabled. > Henceforth, we approve this patch to avoid the ERMS code path on AMD processors for better performance. > > -Sajan > > Thanks for checking this out Sajan, I will rebase with some wording fixes in comments and double check if everything is ok. If you can, please send a Ack-by or Reviewed-by in the next comment. I will also check with H.J and Noah (x86 maintaners) to see if everything is ok.