From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by sourceware.org (Postfix) with ESMTPS id 508873858401 for ; Mon, 3 Oct 2022 14:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 508873858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vk1-xa2a.google.com with SMTP id e5so5565438vkg.6 for ; Mon, 03 Oct 2022 07:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=GHef1kyBQpq9hn4Yj1T4+6LqP687tbD7lrZE6PdVjV8=; b=YscyXwulvQjN64/oduc3PcbStmfEpUIOj5plMyyYnjS9w9VlRwK3jIsbpyj9trnLuV cQtomHdkoz3VNdl/+8lC2OvqcQTsKhLgewqBd1QuwLGqo2oicImoMDz3o91oQ060fEJZ AzreejCt4MXTS9dU6MWY0grh5IcS9b+f5JZvAinPgEOVKlhz5GIRw52PG6V4QZDYnuLY DEO5WHXGn/DgbW+uedTplnWHHE09gUoaequV9ZYzqNEJ2N3gyUVnS/J22EQSGZA7IGGA pUwCEh2T4gJqv1D2dtRMp7M6v9U4FBBCTK0Vglvprkpo0aOU69j+e+KchgrxVI89u58F Y82w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=GHef1kyBQpq9hn4Yj1T4+6LqP687tbD7lrZE6PdVjV8=; b=M63U2V6A+Imt3sqSK0TPv6HA/sDYHg+lWB+xSVZpD+yw6IUl1McrmXuwhWnlwzkob7 hoqrejgXJdBLMM9TQ7GG4/JLdq1JKDopg8DJr2SKLZPZUYqgqDhQoNmYKr1UK7Az/RJH jcdMVG1iVcqMuBW3qRRsXUKxZ7it2v4sBdiS1ICpMOxt8UxlD+0zimb+Z011pNgojoS0 /8MktjDP7DQMvQJYbG8xgLrdqxUF4QZJnKdrFhL6Z8kB+bt2Tntc6TSwY5v0kE0ferrQ 1hMcY/c9VETdFyr/qsocRfRlcUSOBh1aacBqU1sCtO2uJkOdDEKMNjymGJ5DuO3T8Ha/ +w2w== X-Gm-Message-State: ACrzQf2N6mv6oG7POOUtwXCQp6UDPQ0DNlRFH7wwLDnIKOWorIvgmaz9 +cSUqcIIGu53K/rfwMJYY4lN+WUN8ZxOBbhG X-Google-Smtp-Source: AMsMyM7GkT7zY7JJJUSvqSw8px2q7djieK32SV7Rh9IoBeS/61s8RfigHPIjwodG0i11tFyIUjfpGw== X-Received: by 2002:a1f:2ed8:0:b0:3a2:a7f:3e9e with SMTP id u207-20020a1f2ed8000000b003a20a7f3e9emr9351106vku.7.1664809009558; Mon, 03 Oct 2022 07:56:49 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:b87d:f936:fc03:6bdb:fa59? ([2804:1b3:a7c2:b87d:f936:fc03:6bdb:fa59]) by smtp.gmail.com with ESMTPSA id p8-20020a1fa608000000b003a280af417dsm7832812vke.36.2022.10.03.07.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 07:56:49 -0700 (PDT) Message-ID: Date: Mon, 3 Oct 2022 11:56:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 1/8] x86_64: Remove platform directory library loading test Content-Language: en-US To: Javier Pello , libc-alpha@sourceware.org References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu> <87h71l9crb.fsf@oldenburg.str.redhat.com> <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> <87h71i6rfa.fsf@oldenburg.str.redhat.com> <20220914200724.8e685fbbaf441c96d19011c6@otheo.eu> <20220917161748.2b76e1731a27eb78880ee57c@otheo.eu> <20220927200352.0424a12908a437fef9d3a7bc@otheo.eu> <20220927200515.8749a18ef6f13beede3f1a60@otheo.eu> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220927200515.8749a18ef6f13beede3f1a60@otheo.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/09/22 15:05, Javier Pello wrote: > This was to test loading of shared libraries from platform > subdirectories, but this functionality is going away in the > following commits. > > Signed-off-by: Javier Pello LGTM, although I think this patch should be move after the functionality is removed. Reviewed-by: Adhemerval Zanella > --- > sysdeps/x86_64/Makefile | 16 ---------------- > sysdeps/x86_64/tst-x86_64-1.c | 26 -------------------------- > sysdeps/x86_64/tst-x86_64mod-1.c | 22 ---------------------- > 3 files changed, 64 deletions(-) > delete mode 100644 sysdeps/x86_64/tst-x86_64-1.c > delete mode 100644 sysdeps/x86_64/tst-x86_64mod-1.c > > diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile > index c19bef2d..3627c565 100644 > --- a/sysdeps/x86_64/Makefile > +++ b/sysdeps/x86_64/Makefile > @@ -57,17 +57,6 @@ $(objpfx)tst-quad2pie: $(objpfx)tst-quadmod2pie.o > CFLAGS-tst-quad1pie.c = $(PIE-ccflag) > CFLAGS-tst-quad2pie.c = $(PIE-ccflag) > > -tests += tst-x86_64-1 > -modules-names += x86_64/tst-x86_64mod-1 > -extra-test-objs += tst-x86_64mod-1.o > -LDFLAGS-tst-x86_64mod-1.so = -Wl,-soname,tst-x86_64mod-1.so > -ifneq (no,$(have-tunables)) > -# Test the state size for XSAVE when XSAVEC is disabled. > -tst-x86_64-1-ENV = GLIBC_TUNABLES=glibc.cpu.hwcaps=-XSAVEC > -endif > - > -$(objpfx)tst-x86_64-1: $(objpfx)x86_64/tst-x86_64mod-1.so > - > ifneq (no,$(have-tunables)) > tests += tst-platform-1 > modules-names += tst-platformmod-1 x86_64/tst-platformmod-2 > @@ -208,11 +197,6 @@ tests += \ > tst-rsi-wcslen > endif > > -$(objpfx)x86_64/tst-x86_64mod-1.os: $(objpfx)tst-x86_64mod-1.os > - $(make-target-directory) > - rm -f $@ > - ln $< $@ > - > do-tests-clean common-mostlyclean: tst-x86_64-1-clean > > .PHONY: tst-x86_64-1-clean > diff --git a/sysdeps/x86_64/tst-x86_64-1.c b/sysdeps/x86_64/tst-x86_64-1.c > deleted file mode 100644 > index 550439e5..00000000 > --- a/sysdeps/x86_64/tst-x86_64-1.c > +++ /dev/null > @@ -1,26 +0,0 @@ > -/* Test searching the "x86_64" directory for shared libraries. > - Copyright (C) 2017-2022 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -extern void foo (void); > - > -int > -main (void) > -{ > - foo (); > - return 0; > -} > diff --git a/sysdeps/x86_64/tst-x86_64mod-1.c b/sysdeps/x86_64/tst-x86_64mod-1.c > deleted file mode 100644 > index a80458c4..00000000 > --- a/sysdeps/x86_64/tst-x86_64mod-1.c > +++ /dev/null > @@ -1,22 +0,0 @@ > -/* Test searching the "x86_64" directory for shared libraries. > - Copyright (C) 2017-2022 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -void > -foo (void) > -{ > -}