From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Joe Simmons-Talbott <josimmon@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3] resolv/nss_dns/dns-host: Get rid of alloca.
Date: Mon, 14 Aug 2023 10:23:38 -0400 [thread overview]
Message-ID: <aa068e3c-ab85-b716-f0c1-b75527c44309@gotplt.org> (raw)
In-Reply-To: <20230814141103.2387799-1-josimmon@redhat.com>
On 2023-08-14 10:10, Joe Simmons-Talbott via Libc-alpha wrote:
> Since the alloca is a small constant size use an array instead.
> ---
> Changes to v2:
> * Move tmp back into lower scope
>
> resolv/nss_dns/dns-host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c
> index 1d60c51f5e..160a017d42 100644
> --- a/resolv/nss_dns/dns-host.c
> +++ b/resolv/nss_dns/dns-host.c
> @@ -395,8 +395,8 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat,
> */
> if (strchr (name, '.') == NULL)
> {
> - char *tmp = alloca (NS_MAXDNAME);
> - const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME);
> + char tmp[NS_MAXDNAME];
> + const char *cp = __res_context_hostalias (ctx, name, tmp, sizeof (tmp));
> if (cp != NULL)
> name = cp;
> }
prev parent reply other threads:[~2023-08-14 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 14:10 Joe Simmons-Talbott
2023-08-14 14:23 ` Andreas Schwab
2023-08-14 14:28 ` Siddhesh Poyarekar
2023-08-14 15:01 ` Joe Simmons-Talbott
2023-08-14 14:23 ` Siddhesh Poyarekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa068e3c-ab85-b716-f0c1-b75527c44309@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).