From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 37CF43858D20 for ; Fri, 31 Mar 2023 05:09:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37CF43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1033.google.com with SMTP id c4so3344151pjs.4 for ; Thu, 30 Mar 2023 22:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680239360; x=1682831360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uQl0Gu7ImtLLTot1HwvWnGs8hqqV8bVHcaUEPtMk/UQ=; b=XlUWjeHLi047lPFzPPejqsNyw0/q4nAsyOUAIUr8sefaVvgDSih/x74yeKJAwdPrm2 HGLY05oRiKIYCEuwF/7BEWXeoACh8h3orAnS/Np45jT3A+kw2WPyO7vVcrkcu0P0Fbe3 oeNzE4HAgKMPxGfajxKxt4A1F6aaEjr6XJr7WYal0Ve+jP0kHAxK7u9YajmLh/8/MFrm TI7ruDOeyqvb+ri161HOpsarFk6CPK3CDzmBeJiqDbsxzAluasCUF146Ap1VnzxsVW6/ 24it4nmQAYhmsD4EGCUFlc2DpsFlZ/hmpWz9cJ5yBmKsuciAXo6DOx0aBqCKcTQ/Mp/j BD6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680239360; x=1682831360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uQl0Gu7ImtLLTot1HwvWnGs8hqqV8bVHcaUEPtMk/UQ=; b=oNvd2Rcp0TCh9j7NBSi6eTaKbxcXsc99JQgDWRHzWkuTBN7JyVUZf+TKYK20UCAeou Y+S1m226Iw24meTk6SlPXxzod/cQ2FsokgXkuOqZERVa9L2Mck9Hmj58J7pNRR82qkct dTSQobi1Y5jF20rgdck5FKdIdlnk7sPFrSW5Do3LeTh/zsavCPmgJp3d66Vl+U4rnQHn 1SUxU02iUtWh49cBPAT99QPou1LD2InnqG53GC2TNkPcWvlB24uULcxvyMFW4bH/3ohS xu4nmtG4nq2yR0Kbu8w63LaJoEfAEzbcVlTnOMcGpE1GzQ5v5Gvp+lUv2ZCjU2IyCa6A RKfQ== X-Gm-Message-State: AAQBX9fttPUy/1nc2RX9Bq1hHg+aoQCt1IJy1L1vcjNaZlVdY4tqSMfL RktroArECm2BSoCu2rJ7zFAo53IhfMw= X-Google-Smtp-Source: AKy350b07/5Xf86rZNVOqrjogBUStGADoXedyDLMutpR2NS8pgwSkQl08arzxuAIRwblb0K1Sf9bMQ== X-Received: by 2002:a17:90b:350e:b0:234:889f:c35d with SMTP id ls14-20020a17090b350e00b00234889fc35dmr28795637pjb.3.1680239360182; Thu, 30 Mar 2023 22:09:20 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id rj3-20020a17090b3e8300b0023f685f7914sm4083595pjb.49.2023.03.30.22.09.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 22:09:19 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 23:09:13 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 0/3] RISC-V: ifunced memcpy using new kernel hwprobe interface Content-Language: en-US To: Evan Green Cc: Palmer Dabbelt , adhemerval.zanella@linaro.org, libc-alpha@sourceware.org, slewis@rivosinc.com, Vineet Gupta References: <9290df69-8946-3b67-63ea-3d386a3c30a6@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/30/23 12:43, Evan Green wrote: > On Wed, Mar 29, 2023 at 11:20 PM Jeff Law wrote: >> >> >> >> On 3/29/23 13:45, Palmer Dabbelt wrote: >> >>> It's not in for-next yet, but various patch sets / proposals have been >>> on the lists for a few months and it seems like discussion on the kernel >>> side has pretty much died down. That's why I was pinging the glibc side >>> of things, if anyone here has comments on the interface then it's time >>> to chime in. If there's no comments then we're likely to end up with >>> this in the next release (so queue into for-next soon, Linus' master in >>> a month or so). >> Right. And I've suggested that we at least try to settle on the various >> mem* and str* implementations independently of the kernel->glibc >> interface question. > > This works for me. As we talked about off-list, this series cleaves > pretty cleanly. One option would be to take this series now(ish, > whenever the kernel series lands), then cleave off my memcpy and > replace it with Vrull's when it's ready. The hope being that two > incremental improvements go faster than waiting to try and land > everything perfectly all at once. No idea at this point if VRULL's is better or worse ;-) Right now I'm focused on their cboz implementation of memset. Assuming no uarch quirks it should be a slam dunk. But of course there's a quirk in our uarch, so testing testing testing. I did just spend a fair amount of time in the hottest path of their strcmp. It seems quite reasonable. Jeff