From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 71CF9384B0C1 for ; Tue, 21 Apr 2020 11:51:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71CF9384B0C1 Received: by mail-qk1-x744.google.com with SMTP id c63so14145586qke.2 for ; Tue, 21 Apr 2020 04:51:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xm42wkLmTXrD+chv8EI97KHuhJfdQNPfoSIc1tDm7IA=; b=o1WA5mW0zjVWbD5drPszuOUyUoYrKaV/u4VCzjMigcBzwETioOG177M28j/0+t5/2w ktHYMjGhUrOPSXTDrHUvlEGOtGKPaxkA0H6v0VY0uMqdJARj/6xvRE8U/nUAYmJ8a1Pw sioOHjWTemF4xYsk8tK3jf5Muei6BJd01E8Nztcbtp7ROVPLT5ewSMMHK4QAGHMkuQ91 zV9Caq71cpv5mzOOQDYySFuad3SFWERpTNEBN1TpIcQcXdgNmPc7/Gv2alpY7lytRrhT Yl4/Z5u13t6fJuBzBmNu/JCnFVl78V/luBKaEbhOyL+h57ArrCfYauPnn5goC06/7a79 PdVQ== X-Gm-Message-State: AGi0PuZMa1ujUM9YHbbDWx96xd9SD1icO3iSpm6lORRI4BY89gbJLsuy 4sbCeMks3eqRm6Hr3k8D7bsip78hq0UafQ== X-Google-Smtp-Source: APiQypLOieDfhh9xK81mrVNbhKhfUi3OhwqSVM1VvPAEcN1btRWiDd633pqysyMOx9Rli0j91eaa9g== X-Received: by 2002:a05:620a:1458:: with SMTP id i24mr20633547qkl.279.1587469901828; Tue, 21 Apr 2020 04:51:41 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id a27sm1611101qtb.26.2020.04.21.04.51.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2020 04:51:41 -0700 (PDT) To: Andreas Schwab , Adhemerval Zanella via Libc-alpha References: <20200417132209.22065-1-adhemerval.zanella@linaro.org> <87pnc2i4y1.fsf@igel.home> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 01/10] linux: Move posix dir implementations to Linux Message-ID: Date: Tue, 21 Apr 2020 08:51:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87pnc2i4y1.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-25.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 11:51:43 -0000 On 20/04/2020 11:53, Andreas Schwab wrote: > On Apr 17 2020, Adhemerval Zanella via Libc-alpha wrote: > >> This generic implementation already expects a getdents API which >> is Linux specific. > > It is also provided by FreeBSD, though. Either getdirentries or getdents could be used (on FreeBSD getdents is implemented on top of getdirentries). Another reason to move the implementation to be Linux only is further fixes in this patch set would make the generic implementation somewhat more complex (since Linux dirstream would deviate from generic). > >> diff --git a/sysdeps/unix/sysv/linux/alpha/bits/dirent.h b/sysdeps/unix/sysv/linux/alpha/bits/dirent.h >> index 953d590cff..649b6bcb78 100644 >> --- a/sysdeps/unix/sysv/linux/alpha/bits/dirent.h >> +++ b/sysdeps/unix/sysv/linux/alpha/bits/dirent.h >> @@ -47,9 +47,9 @@ struct dirent64 >> #define d_fileno d_ino /* Backwards compatibility. */ >> >> #undef _DIRENT_HAVE_D_NAMLEN >> -#define _DIRENT_HAVE_D_RECLEN >> -#define _DIRENT_HAVE_D_OFF >> -#define _DIRENT_HAVE_D_TYPE >> +#define _DIRENT_HAVE_D_RECLEN 1 >> +#define _DIRENT_HAVE_D_OFF 1 >> +#define _DIRENT_HAVE_D_TYPE 1 >> >> /* Inform libc code that these two types are effectively identical. */ >> #define _DIRENT_MATCHES_DIRENT64 1 >> diff --git a/sysdeps/unix/sysv/linux/bits/dirent.h b/sysdeps/unix/sysv/linux/bits/dirent.h >> index 9e4df8a58b..82c38d9ef8 100644 >> --- a/sysdeps/unix/sysv/linux/bits/dirent.h >> +++ b/sysdeps/unix/sysv/linux/bits/dirent.h >> @@ -47,9 +47,9 @@ struct dirent64 >> #define d_fileno d_ino /* Backwards compatibility. */ >> >> #undef _DIRENT_HAVE_D_NAMLEN >> -#define _DIRENT_HAVE_D_RECLEN >> -#define _DIRENT_HAVE_D_OFF >> -#define _DIRENT_HAVE_D_TYPE >> +#define _DIRENT_HAVE_D_RECLEN 1 >> +#define _DIRENT_HAVE_D_OFF 1 >> +#define _DIRENT_HAVE_D_TYPE 1 > > That part does not fit here. Also, all occurences still use #ifdef. Ack, I have removed it.