From: Carlos O'Donell <codonell@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 0/4] Avoid malloc symbol interposition in the dynamic loader [BZ #25486]
Date: Fri, 14 Feb 2020 22:36:00 -0000 [thread overview]
Message-ID: <aa551428-b961-51d7-7283-030a8f4138ff@redhat.com> (raw)
In-Reply-To: <cover.1581182210.git.fweimer@redhat.com>
On 2/8/20 2:00 PM, Florian Weimer wrote:
> I initially wanted to close this bug, but Carlos suggested to treat it
> as an RFE. The changes seem a net improvement to me.
>
> This does not completely resolve the issue because we use symbol
> interposition for other, more obscure things.
>
> Florian Weimer (4):
> elf: Introduce the rtld-stubbed-symbols makefile variable
> elf: Extract _dl_sym_post, _dl_sym_find_caller_map from elf/dl-sym.c
> Remove weak declaration of free from <inline-hashtab.h>
> ld.so: Do not export free/calloc/malloc/realloc functions [BZ #25486]
Thank you for the cleanup and improvement!
Overall the architecture of the design looks good to me.
I really like the new explicit handover!
--
Cheers,
Carlos.
next prev parent reply other threads:[~2020-02-14 22:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 19:01 Florian Weimer
2020-02-08 19:01 ` [PATCH 2/4] elf: Extract _dl_sym_post, _dl_sym_find_caller_map from elf/dl-sym.c Florian Weimer
2020-02-14 22:36 ` Carlos O'Donell
2020-02-08 19:01 ` [PATCH 3/4] Remove weak declaration of free from <inline-hashtab.h> Florian Weimer
2020-02-14 22:36 ` Carlos O'Donell
2020-02-08 19:01 ` [PATCH 1/4] elf: Introduce the rtld-stubbed-symbols makefile variable Florian Weimer
2020-02-14 22:36 ` Carlos O'Donell
2020-02-08 19:02 ` [PATCH 4/4] ld.so: Do not export free/calloc/malloc/realloc functions [BZ #25486] Florian Weimer
2020-02-14 22:36 ` Carlos O'Donell
2020-02-24 11:53 ` Florian Weimer
2020-02-14 22:36 ` Carlos O'Donell [this message]
2020-02-17 12:26 ` [PATCH 0/4] Avoid malloc symbol interposition in the dynamic loader " Lucas A. M. Magalhaes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa551428-b961-51d7-7283-030a8f4138ff@redhat.com \
--to=codonell@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).