From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id D0D8E3858D33 for ; Mon, 15 Mar 2021 13:59:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0D8E3858D33 Received: by mail-qk1-x72b.google.com with SMTP id t4so31720580qkp.1 for ; Mon, 15 Mar 2021 06:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ogIQHPdDpDTWIdm9/X/43LFOYJPFtsp86GtJv0eplJw=; b=HK1vc8F2duXpboi/mshfK9W47Qwln2l2fKW4o/EYteuaUxeUhhcumW5WsT4LUGjkGn ns3OVrJd7jnhVC1ENJGIr0rLHIvU/IAiZfPLckLe8xS+mIfxDHM/VjNeenlpehCfgpxM YTkO04XXTDrsS5aVlJisa/cg0wHXvcfzt8ZEh4BsciHPqTjPpfgulGXMq74WbedZZ5QL Ui7hnhL3d3EMXnZmJSGwKH+/fqE7vzzo8rDr9qgizS8Nwy2Bk6m3EEBWAgX/tjbgWbWs sOoYD2C2oWCrudIvjiQsnGYv6tsWATuHZDdoBEo/GFTaLDhGMJg90i/+5xheqm3R8t99 rh4A== X-Gm-Message-State: AOAM53340f2stnTyVDQA4E+9Yk2opQyL1URGuEJSAa72xYmORQpZhcP+ 7Tog6+2BA6/BN08SqMf9BtsP6k8nN4OAj9UN X-Google-Smtp-Source: ABdhPJyYQA+EYu3oyEdTQtv6iQHsBNs05FV9t6kxTJVGoJS9B4k+VbO+T4W/urTK8pSFe6jNCR8zrA== X-Received: by 2002:a05:620a:2a0f:: with SMTP id o15mr25034383qkp.153.1615816749267; Mon, 15 Mar 2021 06:59:09 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id q64sm11110659qtd.32.2021.03.15.06.59.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 06:59:08 -0700 (PDT) Subject: Re: [PATCH 1/3] Add inhibit_stack_protector to ifuncmain9 [BZ #25680] To: libc-alpha@sourceware.org References: <20210310101400.3904724-1-siddhesh@sourceware.org> <20210310101400.3904724-2-siddhesh@sourceware.org> From: Adhemerval Zanella Message-ID: Date: Mon, 15 Mar 2021 10:59:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210310101400.3904724-2-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 13:59:11 -0000 On 10/03/2021 07:13, Siddhesh Poyarekar via Libc-alpha wrote: > From: David Hughes > > Enabling --enable-stack-protector=all causes the following tests to fail: > > FAIL: elf/ifuncmain9picstatic > FAIL: elf/ifuncmain9static > > Nick Alcock (who committed the stack protector code) marked the IFUNC > resolvers with inhibit_stack_protector when he done the original work and > suggested doing so again @ BZ #25680. This patch adds > inhibit_stack_protector to ifuncmain9. > > After patch is applied, --enable-stack-protector=all does not fail the > above tests. LGTM, based on previous discussions. Reviewed-by: Adhemerval Zanella > --- > elf/ifuncmain9.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c > index 2c4e95a051..e775c5cfa9 100644 > --- a/elf/ifuncmain9.c > +++ b/elf/ifuncmain9.c > @@ -43,6 +43,7 @@ implementation (void) > } > > static __typeof__ (implementation) * > +inhibit_stack_protector > resolver (void) > { > ++resolver_called; >