From: Alexander Monakov <amonakov@ispras.ru>
To: DJ Delorie <dj@redhat.com>
Cc: Kir Kolyshkin <kolyshkin@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Linux: add ST_NOSYMFOLLOW
Date: Sun, 24 Sep 2023 14:52:56 +0300 (MSK) [thread overview]
Message-ID: <aae2b4d6-986d-9227-a21f-465b369d01a3@ispras.ru> (raw)
In-Reply-To: <xnjzsi0ypl.fsf@greed.delorie.com>
On Fri, 22 Sep 2023, DJ Delorie wrote:
> Kir Kolyshkin <kolyshkin@gmail.com> writes:
> > - ST_RELATIME = 4096 /* Update atime relative to mtime/ctime. */
> > + ST_RELATIME = 4096, /* Update atime relative to mtime/ctime. */
>
> Comma, ok.
>
> > # define ST_RELATIME ST_RELATIME
> > + ST_NOSYMFOLLOW = 8192, /* Do not follow symlinks. */
> > +# define ST_NOSYMFOLLOW ST_NOSYMFOLLOW
>
> Matches the kernel, Ok.
It adds a trailing enum comma (invalid in C prior to C99 and C++ prior to C++11)
while it was correctly omitted before.
Alexander
next prev parent reply other threads:[~2023-09-24 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 0:14 Kir Kolyshkin
2023-09-22 19:55 ` DJ Delorie
2023-09-24 11:52 ` Alexander Monakov [this message]
2023-09-27 22:00 ` [PATCH v2] " Kir Kolyshkin
2023-09-27 22:37 ` [PATCH v3] " Kir Kolyshkin
2023-09-28 12:51 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aae2b4d6-986d-9227-a21f-465b369d01a3@ispras.ru \
--to=amonakov@ispras.ru \
--cc=dj@redhat.com \
--cc=kolyshkin@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).