From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8053E385772D for ; Thu, 7 Mar 2024 20:44:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8053E385772D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8053E385772D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709844250; cv=none; b=h73hSgzbhiFIvLUyNAv1iLUtDXwQEMqLSPD31ULKieNxcV39xbLKmkwgCUWans5MjjTa8mopwHKTumsCQUKxQ4UmmgG5NaYGhvzkpTfJjWVO/J1jKpVMkS3u8yhqzBpsjHSXnAUXF/1fK570ry+jGkBNVynrKqTT9qJ22jVt1So= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709844250; c=relaxed/simple; bh=J12U2xUauvi+gSXcKK5jmyf1ckvU2AYUK4vxkR05amg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=v4JDaOJpkufngwJmlgN1D7etKqs83Vr2X9FdDR1cTgdDgXhBLvU1NzRNTLJUsFj7dsEC4mupPWX6AhGjj0ZXsPj7DppH9Foi26a1eEPf0zAz3cepKgii1pmIEo0JBx51bIqdIKLkOW7Ontam8qkuA6WvMIoR3324UPSvp0HKx5I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709844249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTC0Zg3jeJG4LIkJfQVSPM+v2aSpJORiDap/nn5wdFA=; b=I6t+YFKBe99CgC2mOGaz1Nd81ARqtD1f+gt3L0YbKs8wBgkTCeosTUe69/UUhQ3lFjLKVa 79ip2HsVZup/seER10aeVQ7ovy1LrrGEhmYWVr5QNxTaAbOwWdWyJD/nzjxdetv3j45xcW 6SRJ0/TC2lYHnKBs+7V0O2Er/IW62yk= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-_hVmoyQWNpCpn45E4XVvgQ-1; Thu, 07 Mar 2024 15:44:05 -0500 X-MC-Unique: _hVmoyQWNpCpn45E4XVvgQ-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5a0acbbca3bso1449940eaf.2 for ; Thu, 07 Mar 2024 12:44:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709844245; x=1710449045; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jTC0Zg3jeJG4LIkJfQVSPM+v2aSpJORiDap/nn5wdFA=; b=TNRcHAMuoiAVNotLjiSwq/LLWKPkf4j4TOBXQT5wex4d9NzFbj4yMiGZjAeyiOFwtt v8OKwyBDqMCBN02XqwNYNVEOW7WjdHbxUnYICdcWYLOFrr+Z8bBxOQOtBDQXJEB9+fOy ORVdnhYXTYDarkQwhU8N/9dSul2yDl1CbUP1ZsjBXNcWEOz/1G3zPYkIRK6uCXo+xYjY fc8FdQLOFlL01HyCUOc4tRLDJhoPIDezxsDC1LjxP4LWjx1xpaMylfjv1NXGpNnacP11 8jdtp/TdGJSBObKNU9jAOl18RZooiARxnlFFAXBL6O4PuOp4UsXPvaLzlfSzCdbyTfFy +ZDA== X-Gm-Message-State: AOJu0YzL+pifSCzk20KiZ8N65wkCFhMYc+pvnxj03NLG4cYFEf0fdz78 KyuG5xbqJzCZBguNimO3i3s1SJhqK3W77dShwcC1SFy95z3Djv4Vr+O6F3er9uyIfxDxFW5hRUv /lgyz9rt9prmn0/xzFXNu39Z/IGLpf5q+Wcem2Gzd0yn/syZqswdAvSXtYQ== X-Received: by 2002:a05:6358:884:b0:17c:20cb:b562 with SMTP id m4-20020a056358088400b0017c20cbb562mr10092671rwj.12.1709844244934; Thu, 07 Mar 2024 12:44:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IG051h18+Ka3GjGQax2s0B7PRcFKnvbCwlKIywrz2VP5eq9jstc/+txKIJik6skBu5oUJ6+Tw== X-Received: by 2002:a05:6358:884:b0:17c:20cb:b562 with SMTP id m4-20020a056358088400b0017c20cbb562mr10092611rwj.12.1709844243522; Thu, 07 Mar 2024 12:44:03 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id g2-20020a05620a108200b007884103dfcesm1926180qkk.87.2024.03.07.12.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 12:44:02 -0800 (PST) Message-ID: Date: Thu, 7 Mar 2024 15:44:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Don't check signatures in build-many-glibcs.py To: Simon Chopin , Palmer Dabbelt Cc: libc-alpha@sourceware.org References: <20240112185846.24483-1-palmer@rivosinc.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/24 05:39, Simon Chopin wrote: > Hi Palmer, thanks for the patch. > > On ven. 12 janv. 2024 10:58:46, Palmer Dabbelt wrote: >> I sign commits and have signature verification on in git. Maybe that's >> a bad idea because it trips up a bunch of scripts, but it's pretty easy >> to just force skipping signature verification here. > > Presumably, there's all kind of things that could go wrong if the user > has some particular git configuration. I feel like this particular can > of worms could be side-stepped entirely if we just set GIT_CONFIG_GLOBAL > to /dev/null (and perhaps used GIT_CONFIG_NOSYSTEM=1 for good measure) > to clear any interfering custom config. I agree completely. If we need to we should reset tooling *defaults* so bmg runs as expected. > WDYT? > >> >> Signed-off-by: Palmer Dabbelt >> --- >> scripts/build-many-glibcs.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py >> index ec2ded6e56..f9cf14c94d 100755 >> --- a/scripts/build-many-glibcs.py >> +++ b/scripts/build-many-glibcs.py >> @@ -931,7 +931,7 @@ class Context(object): >> if self.replace_sources: >> subprocess.run(['git', 'clean', '-dxfq'], >> cwd=self.component_srcdir(component), check=True) >> - subprocess.run(['git', 'pull', '-q'], >> + subprocess.run(['git', 'pull', '-q', '--no-verify-signatures'], >> cwd=self.component_srcdir(component), check=True) >> else: >> if self.shallow: >> -- >> 2.43.0 >> > -- Cheers, Carlos.