From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 605C73847725 for ; Wed, 3 Apr 2024 19:54:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 605C73847725 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 605C73847725 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712174063; cv=none; b=H6GCjZf3oz6se7jVgIv9DDX2xuXNVEWcXKeuJk03BWxcEG8FniFs+ycqo4J3qcHefxHsd7eDFIzEvoNmMB8Y1/4nss4wE7qbTCZSh0OxJiXU5jjdt753CyJshVvDhH9J6Gx2Lem6bKpBcpUe2xKXp6IZNm/ufzGhGtjaywMbJV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712174063; c=relaxed/simple; bh=YeO2U5ri/KpqX4MakOzE+jv0dDgi9fd9ke4ONKDoCZY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HOX8j1HH77rXUUc8NRZv2TlaWHSley8V0R9ewrGLbT8fLxTGzh9a46GlbdsWDpquOWjWycWEWgVzEvA2tf90kpJ3i6tdOKrhLnAVqmhHmeg/dA3DGrbIitSK5P4CezpvmWg2wPEa7OP2XUkkUAMAGepj8zETGJbM+k25aFIUTPs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6e6ca2ac094so201534b3a.0 for ; Wed, 03 Apr 2024 12:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712174060; x=1712778860; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=2aYD7dxgCEf5ZZImeW1axaNrCrpQRNk+xhXprkrB144=; b=Wmjlh77fNpemuqkZqAI2FojDax5grhl9DvZEFfBANfwwtlxQRp59M8I4ZX7opUH1D1 SEdfcv6aUGvDGjJo1SHmp+0cfp6VFb3rPzKaJlFb9MgcRldtayrbkqxo1mU3XQ4ndOL0 he0if99/wdwLEV3HuBjQTnScF7E2LH07qfvgKXZaC+jdNkTtCMKXcPt9GX7kltwDPUPx +qUQglOXGpegvxrVZS2Ceyw1kW7OtGtCN71uH8D5rXjhMYZahiXAoOFW2odFweNeINK2 jQg8jKjBS/ZQLvK5POvA/kmI8z7Xc5xtlw9/szDOFJKi8Kb3djHnmVKO16XXKTDRQ709 qHrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712174060; x=1712778860; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2aYD7dxgCEf5ZZImeW1axaNrCrpQRNk+xhXprkrB144=; b=mg7oVR1tGIK6raYQSuse470aiSUFWRExwlgNWbudoVg1lrKIBDg6zGefbtMhXxY0ni sfZI+JaFOw/TzjMvPlqahrgpyfZHFxXfZtaFt/rTufmNfvOPID575O7XRMTayqhkspKn 4uwlnOZiufvK4kI9G3YgQLfzc323ibO0EWDy80n9Px53XHsq/nztOgOm4I8IN5qVTHvx zo3i3R81OrCskg8a0YsbS/Jc4eJjYBJ8CP7FlpIJGj/pC0d0J64K/uMiddRAECzp7m5e S90mYmKCAdSZPkq/WT5hjGh7Wcluam/wxyIorsv2ioXIBeN7AB1t1O41koHF34Z9/lzo XWnQ== X-Gm-Message-State: AOJu0YzTE9fMEajIJvQJzVeIZQC3COE5U92md2dvjvs84tVK9ZGdp5Tx UWo0sl9w1T3IrLAwyvfvcRBCq0hXAkjItAG+54UqydwStjNwHtUpO0FKrREF/vmBIezB0MWF4rQ l X-Google-Smtp-Source: AGHT+IEojWdD9rwCZqXV4VJtkSPRMBum4DAQRDwlsnPmI0OSLHiTPeEQ6uatG0tpvI4g/GEktD2vAA== X-Received: by 2002:a05:6a20:12c2:b0:1a3:c3a1:6421 with SMTP id v2-20020a056a2012c200b001a3c3a16421mr781436pzg.44.1712174059716; Wed, 03 Apr 2024 12:54:19 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af? ([2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af]) by smtp.gmail.com with ESMTPSA id z6-20020aa791c6000000b006eac44e402csm12171556pfa.23.2024.04.03.12.54.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 12:54:19 -0700 (PDT) Message-ID: Date: Wed, 3 Apr 2024 16:54:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] elf: Don't call fatal_error in _dl_signal_error To: libc-alpha@sourceware.org, "H.J. Lu" References: <20240403123928.165033-1-hjl.tools@gmail.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240403123928.165033-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/04/24 09:39, H.J. Lu wrote: > Don't call fatal_error in _dl_signal_error since _dl_signal_error should > only be called from _dl_catch_exception and get_catch should never return > NULL. Otherwise, fatal_error should be called directly instead. Is this related to BZ#31596 or did you catch it by code review? I think this is required for lazy binding being fatal error on initializer functions (elf/dl-open.c:829). > --- > elf/dl-catch.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/elf/dl-catch.c b/elf/dl-catch.c > index 2109516dba..a023555165 100644 > --- a/elf/dl-catch.c > +++ b/elf/dl-catch.c > @@ -117,16 +117,11 @@ _dl_signal_error (int errcode, const char *objname, const char *occasion, > if (! errstring) > errstring = N_("DYNAMIC LINKER BUG!!!"); > > - if (lcatch != NULL) > - { > - _dl_exception_create (lcatch->exception, objname, errstring); > - *lcatch->errcode = errcode; > + _dl_exception_create (lcatch->exception, objname, errstring); > + *lcatch->errcode = errcode; > > - /* We do not restore the signal mask because none was saved. */ > - __longjmp (lcatch->env[0].__jmpbuf, 1); > - } > - else > - fatal_error (errcode, objname, occasion, errstring); > + /* We do not restore the signal mask because none was saved. */ > + __longjmp (lcatch->env[0].__jmpbuf, 1); > } > rtld_hidden_def (_dl_signal_error) >