From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 7/7] sysv: linux: Add 64-bit time_t variant for shmctl
Date: Wed, 1 Jul 2020 14:07:00 -0300 [thread overview]
Message-ID: <ab475227-213f-2b97-e787-a0958cf7a4fc@linaro.org> (raw)
In-Reply-To: <aaeb295f-6802-e6b4-ccd9-a05672ed95c6@linaro.org>
On 01/07/2020 13:35, Adhemerval Zanella wrote:
>
>
> On 01/07/2020 12:48, Alistair Francis wrote:
>> On Wed, Jul 1, 2020 at 5:19 AM Adhemerval Zanella
>> <adhemerval.zanella@linaro.org> wrote:
>>>
>>>
>>>
>>> On 30/06/2020 23:28, Alistair Francis wrote:
>>> deps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h b/sysdeps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h
>>>>> new file mode 100644
>>>>> index 0000000000..5533d44dee
>>>>> --- /dev/null
>>>>> +++ b/sysdeps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h
>>>>> @@ -0,0 +1,24 @@
>>>>> +/* Analogous to kernel struct shmid64_ds used on shmctl. */
>>>>> +struct kernel_shmid64_ds
>>>>> +{
>>>>> + struct ipc_perm shm_perm;
>>>>> +#if __TIMESIZE == 64
>>>>> + long int shm_atime;
>>>>> + long int shm_atime;
>>>>> + long int shm_atime;
>>>>
>>>> This fails to compile as all three variables have the same name.
>>>
>>> In fact this code specifically is not used on powerpc since it will
>>> either use the __TIMESIZE == 32 (powerpc32) or not use this
>>> structure at all (powerpc64{le}). But it is still an issue I will
>>> revise the patch for such issues and remove it (maybe adding a
>>> #error if it used on powerpc64).
>>
>> Ah whoops, I commented inline on the wrong file. The generic one
>> (sysdeps/unix/sysv/linux/struct_kernel_shmid64_ds.h) also has the same
>> problem which is why I saw the RISC-V build fail.
>>
>>>
>>> Besides it, does it work for riscv32 (which should use the default
>>> definition)?
>>
>> This patch doesn't work due to the same name variables in a few places
>> (one of them being the generic one).
>>
>
> I need to setup an 32-bit ABI with 64-bit time_t to catch these kind of
> issues.
>
>> I am testing all the other patches and should know by tonight (about 8
>> hours still), I'll let you know.
>
> Ack, you can also do a sniff test with the sysvipc tests to check if
> they are ok.
Ok, the __TIMESIZE should not be used to define the kernel_* struct anyway,
they should be independent of the glibc time ABI selected or defined by
the ABI.
I have updated my personal branch [1] with an updated version and I will
try to check if riscv32 at least built against. If you could also check
it would be helpful.
[1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/semctl-y2038
next prev parent reply other threads:[~2020-07-01 17:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 19:24 [PATCH 1/7] sysv: linux: Add 64-bit time_t variant for semctl Adhemerval Zanella
2020-06-30 19:24 ` [PATCH 2/7] sysvipc: Split out linux struct semid_ds Adhemerval Zanella
2020-07-02 21:20 ` Alistair Francis
2020-07-07 19:01 ` Carlos O'Donell
2020-06-30 19:24 ` [PATCH 3/7] sysvipc: Remove the linux msq-pad.h file Adhemerval Zanella
2020-07-02 21:26 ` Alistair Francis
2020-07-07 19:05 ` Carlos O'Donell
2020-06-30 19:24 ` [PATCH 4/7] sysv: linux: Add 64-bit time_t variant for msgctl Adhemerval Zanella
2020-07-02 21:39 ` Alistair Francis
2020-07-08 18:07 ` Adhemerval Zanella
2020-07-07 19:51 ` Carlos O'Donell
2020-07-08 15:32 ` [PATCH v2] " Adhemerval Zanella
2020-07-08 17:04 ` Carlos O'Donell
2020-07-08 17:56 ` Alistair Francis
2020-06-30 19:24 ` [PATCH 5/7] sysvipc: Split out linux struct shmid_ds Adhemerval Zanella
2020-07-02 21:40 ` Alistair Francis
2020-07-07 19:52 ` Carlos O'Donell
2020-06-30 19:24 ` [PATCH 6/7] sysvipc: Remove the linux shm-pad.h file Adhemerval Zanella
2020-07-07 19:57 ` Carlos O'Donell
2020-06-30 19:24 ` [PATCH 7/7] sysv: linux: Add 64-bit time_t variant for shmctl Adhemerval Zanella
2020-07-01 2:28 ` Alistair Francis
2020-07-01 12:19 ` Adhemerval Zanella
2020-07-01 15:48 ` Alistair Francis
2020-07-01 16:35 ` Adhemerval Zanella
2020-07-01 17:07 ` Adhemerval Zanella [this message]
2020-07-01 20:59 ` Vineet Gupta
2020-07-01 23:00 ` Alistair Francis
2020-07-02 21:41 ` Alistair Francis
2020-07-07 21:33 ` Carlos O'Donell
2020-07-08 15:32 ` [PATCH v2] " Adhemerval Zanella
2020-07-08 17:02 ` Carlos O'Donell
2020-07-08 18:01 ` Alistair Francis
2020-07-10 17:13 ` Joseph Myers
2020-07-10 17:49 ` Adhemerval Zanella
2020-07-10 17:57 ` Joseph Myers
2020-07-10 17:59 ` Adhemerval Zanella
2020-07-02 19:01 ` [PATCH 1/7] sysv: linux: Add 64-bit time_t variant for semctl Alistair Francis
2020-07-07 3:32 ` Carlos O'Donell
2020-07-07 14:09 ` Adhemerval Zanella
2020-07-08 15:32 ` [PATCH v2] " Adhemerval Zanella
2020-07-08 17:04 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab475227-213f-2b97-e787-a0958cf7a4fc@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).