From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 3C93F3857007 for ; Wed, 1 Jul 2020 17:07:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C93F3857007 Received: by mail-qk1-x744.google.com with SMTP id c30so19014624qka.10 for ; Wed, 01 Jul 2020 10:07:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1jevEPpRRiKyBm0fdg29CV9wHzHPqf4c4hSFG5Fqdgo=; b=oeVcXzDOyzWHJeT9OZe7sNc8dA+188hboWDy+bst5ah1lIhviGsSlGPUqtusuQCtlb AdxSQkp33HeAzHXoXhcQqDibAr45eiDmDS5lFm4VvBiXtmdATppSXuyBEchj3opQajI2 U8v8IEF9T2GqvkcbRHatCXuwLpKX8rWvq91sh0YOkalIUb3E/uXdKujbxO2HjMjCUo2U dOZq9EtzGVncNJYn0ICii2H3mrYJwrtbg8ohgejdGu/K1dhWib9Ttz2BxMKqEL9ytKFj TfNouNxdI2Fo+JJnqvp+Nr4yVx1MZTKF0/6rhzyfQyFyeBlNFfxFFsGNQfVpOqiy9hKn gFUg== X-Gm-Message-State: AOAM5330aEL7IjUy3rC8kw8Jn2lpBiSOE4aX1Wx+fJKt3nSypdbIUMaX m9AyNeDDb2cMcn8UpLKwImD+cg== X-Google-Smtp-Source: ABdhPJzTHjhS04oSyphdWNu3vtF5YXhOCCcIqfKaRi/7SLCUsLp195P9qIrY9Q4S+EE5NYXnKr/raw== X-Received: by 2002:a37:7dc3:: with SMTP id y186mr22552612qkc.160.1593623224733; Wed, 01 Jul 2020 10:07:04 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id u58sm6418802qth.77.2020.07.01.10.07.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 10:07:04 -0700 (PDT) Subject: Re: [PATCH 7/7] sysv: linux: Add 64-bit time_t variant for shmctl From: Adhemerval Zanella To: Alistair Francis Cc: GNU C Library , Stepan Golosunov , Alistair Francis References: <20200630192441.3299710-1-adhemerval.zanella@linaro.org> <20200630192441.3299710-7-adhemerval.zanella@linaro.org> <9db39d52-89a5-3411-c210-50b1648fbb09@linaro.org> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Wed, 1 Jul 2020 14:07:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 17:07:06 -0000 On 01/07/2020 13:35, Adhemerval Zanella wrote: > > > On 01/07/2020 12:48, Alistair Francis wrote: >> On Wed, Jul 1, 2020 at 5:19 AM Adhemerval Zanella >> wrote: >>> >>> >>> >>> On 30/06/2020 23:28, Alistair Francis wrote: >>> deps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h b/sysdeps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h >>>>> new file mode 100644 >>>>> index 0000000000..5533d44dee >>>>> --- /dev/null >>>>> +++ b/sysdeps/unix/sysv/linux/powerpc/struct_kernel_shmid64_ds.h >>>>> @@ -0,0 +1,24 @@ >>>>> +/* Analogous to kernel struct shmid64_ds used on shmctl. */ >>>>> +struct kernel_shmid64_ds >>>>> +{ >>>>> + struct ipc_perm shm_perm; >>>>> +#if __TIMESIZE == 64 >>>>> + long int shm_atime; >>>>> + long int shm_atime; >>>>> + long int shm_atime; >>>> >>>> This fails to compile as all three variables have the same name. >>> >>> In fact this code specifically is not used on powerpc since it will >>> either use the __TIMESIZE == 32 (powerpc32) or not use this >>> structure at all (powerpc64{le}). But it is still an issue I will >>> revise the patch for such issues and remove it (maybe adding a >>> #error if it used on powerpc64). >> >> Ah whoops, I commented inline on the wrong file. The generic one >> (sysdeps/unix/sysv/linux/struct_kernel_shmid64_ds.h) also has the same >> problem which is why I saw the RISC-V build fail. >> >>> >>> Besides it, does it work for riscv32 (which should use the default >>> definition)? >> >> This patch doesn't work due to the same name variables in a few places >> (one of them being the generic one). >> > > I need to setup an 32-bit ABI with 64-bit time_t to catch these kind of > issues. > >> I am testing all the other patches and should know by tonight (about 8 >> hours still), I'll let you know. > > Ack, you can also do a sniff test with the sysvipc tests to check if > they are ok. Ok, the __TIMESIZE should not be used to define the kernel_* struct anyway, they should be independent of the glibc time ABI selected or defined by the ABI. I have updated my personal branch [1] with an updated version and I will try to check if riscv32 at least built against. If you could also check it would be helpful. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/semctl-y2038